From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SmmhP-0002qR-Qb
	for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:06:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SmmhJ-0003rm-F9
	for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:06:27 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:46683)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SmmhJ-0003r4-6d
	for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:06:21 -0400
Received: by bkcji1 with SMTP id ji1so132220bkc.4
	for <qemu-devel@nongnu.org>; Thu, 05 Jul 2012 07:06:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1341494619-4714-5-git-send-email-yeongkyoon.lee@samsung.com>
References: <1341494619-4714-1-git-send-email-yeongkyoon.lee@samsung.com>
	<1341494619-4714-5-git-send-email-yeongkyoon.lee@samsung.com>
Date: Thu, 5 Jul 2012 15:06:18 +0100
Message-ID: <CAFEAcA9rwUXmt2b9DaVpm70zHWHeaGsGCyr3R96RMrj60CdDmg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add
 CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yeongkyoon Lee <yeongkyoon.lee@samsung.com>
Cc: laurent.desnogues@gmail.com, e.voevodin@samsung.com, qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw

On 5 July 2012 14:23, Yeongkyoon Lee <yeongkyoon.lee@samsung.com> wrote:
> Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0.

This shouldn't be a user settable config option -- we should
just identify what the optimal setting is for the guest/target
combination and use it.

>  case "$target_arch2" in
>    alpha | sparc* | xtensa* | ppc*)
>      echo "CONFIG_TCG_PASS_AREG0=y" >> $config_target_mak
> +    # qemu_ld/st optimization is not available with CONFIG_TCG_PASS_AREG0
> +    target_ldst_optimization="no"

PASS_AREG0 is the way of the future -- you need to fix the ldst
optimization to work with it.

-- PMM