From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES use
Date: Thu, 24 May 2018 17:46:36 +0100 [thread overview]
Message-ID: <CAFEAcA9sTRXt2EQvarSwUXwL_moPSYZ7vC_y-odRC4QoTZfSPw@mail.gmail.com> (raw)
In-Reply-To: <0d3fb5f8-a8b1-57b8-2f16-294e1f824aab@vivier.eu>
On 24 May 2018 at 16:50, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 24/05/2018 à 17:29, Laurent Vivier a écrit :
>> Le 21/05/2018 à 11:19, Peter Maydell a écrit :
>>> On 19 May 2018 at 10:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>>> to be like in the kernel and rename it TARGET_ARCH_HAS_SOCKET_TYPES
>>>
>>> You could note in the commit message that this fixes our
>>> incorrect definition of TARGET_SOCK_CLOEXEC for SPARC.
>>
>> I agree
>
> In fact it doesn't change the value of TARGET_SOCK_CLOEXEC for SPARC,
> because original value is 020000000 (0x400000) and the new value from
> linux-user/socket.h is TARGET_O_CLOEXEC which is also 0x400000 for SPARC.
Argh, octal vs hex. Thanks for checking that.
-- PMM
next prev parent reply other threads:[~2018-05-24 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 9:29 [Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 1/8] linux-user: move mips socket.h definitions to mips/sockbits.h Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 2/8] linux-user: move alpha socket.h definitions to alpha/sockbits.h Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 3/8] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 4/8] linux-user: move socket.h generic definitions to generic/sockbits.h Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 5/8] linux-user: move ppc socket.h definitions to ppc/sockbits.h Laurent Vivier
2018-05-21 9:05 ` Peter Maydell
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES use Laurent Vivier
2018-05-21 9:19 ` Peter Maydell
2018-05-24 15:29 ` Laurent Vivier
2018-05-24 15:50 ` Laurent Vivier
2018-05-24 16:46 ` Peter Maydell [this message]
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 7/8] linux-user: copy sparc/sockbits.h definitions from linux Laurent Vivier
2018-05-19 9:29 ` [Qemu-devel] [PATCH v3 8/8] linux-user: define TARGET_SO_REUSEPORT Laurent Vivier
2018-05-21 9:52 ` [Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9sTRXt2EQvarSwUXwL_moPSYZ7vC_y-odRC4QoTZfSPw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).