From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DABC63777 for ; Thu, 26 Nov 2020 12:11:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 594812087C for ; Thu, 26 Nov 2020 12:11:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lgrXxBCi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 594812087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiG7K-0003VD-Jc for qemu-devel@archiver.kernel.org; Thu, 26 Nov 2020 07:11:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiG2h-00017c-SS for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:06:31 -0500 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:33598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiG2g-0001tj-61 for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:06:31 -0500 Received: by mail-ej1-x644.google.com with SMTP id 7so2637498ejm.0 for ; Thu, 26 Nov 2020 04:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kpjf8Y8HCgAUQxxZ53cX0oE55KrvZllXNp+tnC8WQVE=; b=lgrXxBCiDNIgWUBEvGpXzcupX1dHtGdh5puewSDV7hec3/6s2f+erOkoxksSZwpDb+ OmJxzqJ+7BvOd7wfomcmJNAn6VFyE+ST1e+xYgzU9ciFKMZgzRUhGBqH5SYo999muvf0 JgkOw3clkS6OP8IfUKqvcQMgZ8o12Lnuf2OWfP5Cda5JLtuxk7cu4Szp/0Ok+ygOAEQi /9Ck08SiAEMhBuPPLDK8WerqK50u7flKo1t4beRDjyWleY32KcloGj82spBMvBJ9XT/F lEXPWUA6YjgrNwm07+IHuNf8z9TnGuX6bVH2JxDHMk71DNfIrOmYoV1H/lcibRjWGYh3 UElQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kpjf8Y8HCgAUQxxZ53cX0oE55KrvZllXNp+tnC8WQVE=; b=Jc6lOknczIXII53F3EeDUZXZyeDLvHfyLskSMbrQE7rgRZZVSbMgol0Am/DdllfJ5K sz1FggQiI4IyNh6bYrLFttf+TNAbxEHPfUZlDk2TIUtmpJNvEB66G0NtXIyR8fXMPaae udLf56Hhxtz0c1Qp68zV2evX/jenLVjrnuVOXp8rwx0PZZTN2Gmj9x48wMnSky1c1kAx Q1ceVfGqbkKP/Ta/eaIbjE6y4+9XxLWpD3huJKyJcheBOR0vls5AKbJ7aTlY5j79cpWW 7NX01Bf7Wb9hWYIBNPR73T8SxIpqoeIm97i1f9Ta+yU8n79mk6XX4KtYtLi1fnRAoeJq MmPw== X-Gm-Message-State: AOAM530XjQD9JGgEC3GtXW0umsqeX4r8w0ZNg/otWkn5zyx0LKwkFRkq zQrfFkG+Ub8M+TVlnE5TkCfapwxvV+MsjigBcAqSxg== X-Google-Smtp-Source: ABdhPJw646vi87iOoZVBdMZgFzmCwKlZc1FZP/mw0ppnu9nXPQuPvXYbgAbkg2Snc+ANqAiqZTLZSFWpfwAAd1P8RXc= X-Received: by 2002:a17:906:d8a9:: with SMTP id qc9mr2361040ejb.482.1606392388678; Thu, 26 Nov 2020 04:06:28 -0800 (PST) MIME-Version: 1.0 References: <20201126112915.525285-1-marcandre.lureau@redhat.com> <20201126112915.525285-10-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-10-marcandre.lureau@redhat.com> From: Peter Maydell Date: Thu, 26 Nov 2020 12:06:17 +0000 Message-ID: Subject: Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::644; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x644.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-Andr=C3=A9 Lureau > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > Drop MSVC fallback path. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > audio/audio.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 46578e4a58..d7a00294de 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -122,13 +122,7 @@ int audio_bug (const char *funcname, int cond) > > #if defined AUDIO_BREAKPOINT_ON_BUG > # if defined HOST_I386 > -# if defined __GNUC__ > - __asm__ ("int3"); > -# elif defined _MSC_VER > - _asm _emit 0xcc; > -# else > - abort (); > -# endif > + __asm__ ("int3"); > # else > abort (); > # endif > -- > 2.29.0 I would prefer to just drop this attempt to emit an inline breakpoint insn (which won't work on non-x86 hosts and seems to me to have no benefit over just calling abort(), which will also drop you into the debugger) and simply make it abort() if AUDIO_BREAKPOINT_ON_BUG is defined. Gerd, do you have an opinion ? thanks -- PMM