From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlvuU-0007cM-TW for qemu-devel@nongnu.org; Tue, 13 Oct 2015 05:30:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlvuR-0005hp-K5 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 05:30:18 -0400 Received: from mail-vk0-f49.google.com ([209.85.213.49]:34306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlvuR-0005hV-Es for qemu-devel@nongnu.org; Tue, 13 Oct 2015 05:30:15 -0400 Received: by vkat63 with SMTP id t63so6653369vka.1 for ; Tue, 13 Oct 2015 02:30:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> From: Peter Maydell Date: Tue, 13 Oct 2015 10:29:55 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v2 00/50] Ivshmem patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: Andrew Jones , Claudio Fontana , QEMU Developers , Stefan Hajnoczi , Paolo Bonzini , Cam Macdonell On 12 October 2015 at 17:40, wrote: > From: Marc-Andr=C3=A9 Lureau > > The following changes since commit 0bf224d5da41967a775b328234cda2d19f3039= 08: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' i= nto staging (2015-10-12 14:29:29 +0100) > > are available in the git repository at: > > git@github.com:elmarco/qemu.git tags/ivshmem-pull-request > > for you to fetch changes up to a3920e445af166ae95651a63bcd0d3b4694eed14: > > doc: document ivshmem & hugepages (2015-10-12 18:02:51 +0200) > > ---------------------------------------------------------------- > This new pull request includes Andreas qtest patch, a doc patch, and > fixes some new glib API usage in tests. > ---------------------------------------------------------------- Hi. I'm afraid this fails to build on OSX: /Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/ivshmem-server.c:13= :10: fatal error: 'sys/even tfd.h' file not found #include ^ CC contrib/ivshmem-server/main.o /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:11= 1:48: warning: format speci fies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] "peer %ld\n", peer_id); ~~~ ^~~~~~~ %lld /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from ma cro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:11= 5:64: warning: format speci fies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] IVSHMEM_CLIENT_DEBUG(client, "delete peer id =3D %ld\n", peer_id); ~~~ ^~~~~~~ %lld /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from ma cro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:12= 6:61: warning: format speci fies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] IVSHMEM_CLIENT_DEBUG(client, "new peer id =3D %ld\n", peer_id); ~~~ ^~~~~~~ %lld /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from ma cro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:13= 1:51: warning: format speci fies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] peer->vectors_count, fd, peer->id); ^~~~~~~~ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from ma cro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:22= 3:50: warning: format speci fies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] IVSHMEM_CLIENT_DEBUG(client, "our_id=3D%ld\n", client->local.id); ~~~ ^~~~~~~~~~~~~~~~ %lld /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from macro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:31= 8:51: warning: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] peer->vectors[i], i, kick); ^~~~ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from macro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:35= 5:30: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] peer->id); ^~~~~~~~ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from macro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:36= 0:26: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] peer->id, vector, fd); ^~~~~~~~ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21= :28: note: expanded from macro 'IVSHMEM_CLIENT_DEBUG' printf(fmt, ## __VA_ARGS__); \ ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:43= 1:30: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] printf("our_id =3D %ld\n", peer->id); ~~~ ^~~~~~~~ %lld /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:43= 9:35: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] printf("peer_id =3D %ld\n", peer->id); ~~~ ^~~~~~~~ %lld 1 error generated. /Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/main.c:182:65: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] printf("receive notification from peer_id=3D%ld vector=3D%d\n", peer->i= d, vect); ~~~ ^~~~~~~~ %lld make: *** [contrib/ivshmem-server/ivshmem-server.o] Error 1 make: *** Waiting for unfinished jobs.... /Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/main.c:107:51: warning: incompatible pointer types passing 'size_t *' (aka 'unsigned long *') to parameter of type 'uint64_t *' (aka 'unsigned long long *') [-Wincompatible-pointer-types] parse_option_size("shm_size", optarg, &args->shm_size, &errp); ^~~~~~~~~~~~~~~ /Users/pm215/src/qemu-for-merges/include/qemu/option.h:44:34: note: passing argument to parameter 'ret' here uint64_t *ret, Error **errp); ^ /Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/main.c:239:13: warning: 'daemon' is deprecated: first deprecated in OS X 10.5 [-Wdeprecated-declarations] if (daemon(1, 1) < 0) { ^ /usr/include/stdlib.h:267:6: note: 'daemon' has been explicitly marked deprecated here int daemon(int, int) __DARWIN_1050(daemon) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_5, __IPHONE_2_0, __IPHONE_2_0); ^ The various format string warnings also cause build failures on 32-bit Linux. thanks -- PMM