From: Peter Maydell <peter.maydell@linaro.org>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, Gan Qixin <ganqixin@huawei.com>,
Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH 2/9] hw/intc/arm_gicv3_kvm: silence the compiler warnings
Date: Wed, 28 Oct 2020 20:20:33 +0000 [thread overview]
Message-ID: <CAFEAcA9uyKHO06aZaKSZefpq_eXs12E+AzHHNbL+=amcfq66Cg@mail.gmail.com> (raw)
In-Reply-To: <20201028041819.2169003-3-kuhn.chenqun@huawei.com>
On Wed, 28 Oct 2020 at 04:19, Chen Qun <kuhn.chenqun@huawei.com> wrote:
>
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> hw/intc/arm_gicv3_kvm.c: In function ‘kvm_arm_gicv3_put’:
> hw/intc/arm_gicv3_kvm.c:484:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, true);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/intc/arm_gicv3_kvm.c:485:9: note: here
> default:
> ^~~~~~~
> hw/intc/arm_gicv3_kvm.c:495:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, true);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/intc/arm_gicv3_kvm.c:496:9: note: here
> case 6:
> ^~~~
> hw/intc/arm_gicv3_kvm.c:498:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, true);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/intc/arm_gicv3_kvm.c:499:9: note: here
> default:
> ^~~~~~~
>
> hw/intc/arm_gicv3_kvm.c: In function ‘kvm_arm_gicv3_get’:
> hw/intc/arm_gicv3_kvm.c:634:37: warning: this statement may fall through [-Wimplicit-fallthrough=]
> c->icc_apr[GICV3_G0][2] = reg64;
> ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> hw/intc/arm_gicv3_kvm.c:635:9: note: here
> case 6:
> ^~~~
> hw/intc/arm_gicv3_kvm.c:637:37: warning: this statement may fall through [-Wimplicit-fallthrough=]
> c->icc_apr[GICV3_G0][1] = reg64;
> ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> hw/intc/arm_gicv3_kvm.c:638:9: note: here
> default:
> ^~~~~~~
> hw/intc/arm_gicv3_kvm.c:648:39: warning: this statement may fall through [-Wimplicit-fallthrough=]
> c->icc_apr[GICV3_G1NS][2] = reg64;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> hw/intc/arm_gicv3_kvm.c:649:9: note: here
> case 6:
> ^~~~
> hw/intc/arm_gicv3_kvm.c:651:39: warning: this statement may fall through [-Wimplicit-fallthrough=]
> c->icc_apr[GICV3_G1NS][1] = reg64;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> hw/intc/arm_gicv3_kvm.c:652:9: note: here
> default:
> ^~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Yep, these are all intentionall fallthrough.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2020-10-28 20:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 4:18 [PATCH 0/9] silence the compiler warnings Chen Qun
2020-10-28 4:18 ` [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Chen Qun
2020-10-28 12:57 ` Thomas Huth
2020-10-28 13:20 ` Philippe Mathieu-Daudé
2020-10-28 15:31 ` Richard Henderson
2020-10-28 16:51 ` Thomas Huth
2020-10-29 2:40 ` Chenqun (kuhn)
2020-10-28 15:31 ` Richard Henderson
2020-10-28 4:18 ` [PATCH 2/9] hw/intc/arm_gicv3_kvm: silence the compiler warnings Chen Qun
2020-10-28 20:20 ` Peter Maydell [this message]
2020-10-28 4:18 ` [PATCH 3/9] accel/tcg/user-exec: " Chen Qun
2020-10-28 13:52 ` Thomas Huth
2020-10-28 15:37 ` Richard Henderson
2020-10-29 6:13 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 4/9] linux-user/mips/cpu_loop: " Chen Qun
2020-10-28 13:22 ` Thomas Huth
2020-10-28 4:18 ` [PATCH 5/9] target/sparc/translate: " Chen Qun
2020-10-28 6:39 ` Artyom Tarasenko
2020-10-28 9:50 ` Philippe Mathieu-Daudé
2020-10-28 4:18 ` [PATCH 6/9] target/sparc/win_helper: " Chen Qun
2020-10-28 6:42 ` Artyom Tarasenko
2020-10-28 9:51 ` Philippe Mathieu-Daudé
2020-10-29 2:45 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 7/9] ppc: " Chen Qun
2020-10-28 4:29 ` David Gibson
2020-10-28 14:42 ` Thomas Huth
2020-10-28 23:38 ` David Gibson
2020-10-29 7:06 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 8/9] target/ppc: " Chen Qun
2020-10-28 4:30 ` David Gibson
2020-10-28 9:56 ` Philippe Mathieu-Daudé
2020-10-28 15:06 ` Thomas Huth
2020-10-28 23:39 ` David Gibson
2020-10-29 7:16 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 9/9] hw/timer/renesas_tmr: " Chen Qun
2020-10-28 9:59 ` Philippe Mathieu-Daudé
2020-10-28 15:04 ` Thomas Huth
2020-10-28 20:14 ` Peter Maydell
2020-10-29 8:26 ` Chenqun (kuhn)
2020-10-29 8:12 ` Chenqun (kuhn)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9uyKHO06aZaKSZefpq_eXs12E+AzHHNbL+=amcfq66Cg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=euler.robot@huawei.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).