Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

[Peter Maydell <peter.maydell@linaro.org>]

On Sat, 12 Oct 2024 at 11:54, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > The following changes since commit b5ab62b3c0050612c7f9b0b4baeb44ebab42775a:
> >
> >   Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-04 19:28:37 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/bonzini/qemu.git tags/for-upstream
> >
> > for you to fetch changes up to 381d2c36e1242f849a55f4622e50b9a69cb92842:
> >
> >   docs: use consistent markup for footnotes (2024-10-11 13:08:32 +0200)
> >
> > v2->v3: new patches
> > - scripts/archive-source: find directory name for subprojects
> > - docs: fix invalid footnote syntax
> > - docs: avoid footnotes consisting of just URLs
> > - docs: use consistent markup for footnotes
> >
> > ----------------------------------------------------------------
> > * first commit for Rust support
> > * add CI job using Fedora + Rust nightly
> > * fix detection of ATOMIC128 on x86_64
> > * fix compilation with Sphinx 8.1.0
> >
>
> Hi; 'make vm-build-openbsd' seems to still fail. It looks
> like the wrap file subprojects/unicode-ident-1-rs.wrap says
> "directory = unicode-ident-1.0.12" and the script correctly
> parses that out of the file, but the directory is actually
> named "unicode-ident-1-rs" (differently from the other rust ones),
> so we don't find it.
>
>
> make: Entering directory '/home/peter.maydell/qemu-openbsd/build'
> /home/peter.maydell/qemu-openbsd/build/pyvenv/bin/meson introspect
> --targets --tests --benchmarks |
> /home/peter.maydell/qemu-openbsd/build/pyvenv/bin/python3 -B
> scripts/mtest2make.py > Makefile.mtest
> { \
>   echo 'ninja-targets = \'; \
>   /usr/bin/ninja -t targets all | sed 's/:.*//; $!s/$/ \\/'; \
>   echo 'build-files = \'; \
>   /usr/bin/ninja -t query build.ninja | sed -n '1,/^  input:/d; /^
> outputs:/q; s/$/ \\/p'; \
> } > Makefile.ninja.tmp && mv Makefile.ninja.tmp Makefile.ninja
> /home/peter.maydell/qemu-openbsd/build/pyvenv/bin/python3 -B
> /home/peter.maydell/qemu-openbsd/tests/vm/openbsd  --debug
> --genisoimage /usr/bin/genisoimage    --source-path
> /home/peter.maydell/qemu-openbsd --image
> "/home/peter.maydell/.cache/qemu-vm/images/openbsd.img"  --build-image
> /home/peter.maydell/.cache/qemu-vm/images/openbsd.img
> Image file exists, skipping build:
> /home/peter.maydell/.cache/qemu-vm/images/openbsd.img
> Use --force option to overwrite
> /home/peter.maydell/qemu-openbsd/build/pyvenv/bin/python3 -B
> /home/peter.maydell/qemu-openbsd/tests/vm/openbsd  --debug  --jobs 8
> --verbose    --image
> "/home/peter.maydell/.cache/qemu-vm/images/openbsd.img"  --snapshot
> --build-qemu /home/peter.maydell/qemu-openbsd --
> DEBUG:root:Creating archive
> /home/peter.maydell/qemu-openbsd/build/vm-test-w7gx56ds.tmp/data-993a1.tar
> for src_dir dir: /home/peter.maydell/qemu-openbsd
> Download keycodemapdb...
>   -> Already downloaded
> Download libvfio-user...
>   -> Already downloaded
> Download berkeley-softfloat-3...
>   -> Already downloaded
> Download berkeley-testfloat-3...
>   -> Already downloaded
> Download arbitrary-int-1-rs...
>   -> Already downloaded
> Download bilge-0.2-rs...
>   -> Already downloaded
> Download bilge-impl-0.2-rs...
>   -> Already downloaded
> Download either-1-rs...
>   -> Already downloaded
> Download itertools-0.11-rs...
>   -> Already downloaded
> Download proc-macro2-1-rs...
>   -> Already downloaded
> Download proc-macro-error-1-rs...
>   -> Already downloaded
> Download proc-macro-error-attr-1-rs...
>   -> Already downloaded
> Download quote-1-rs...
>   -> Already downloaded
> Download syn-2-rs...
>   -> Already downloaded
> Download unicode-ident-1-rs...
>   -> Already downloaded
> tar: subprojects/unicode-ident-1.0.12: Cannot stat: No such file or directory
> tar: Exiting with failure status due to previous errors
> failed to append subproject unicode-ident-1-rs to
> /home/peter.maydell/qemu-openbsd/build/vm-test-w7gx56ds.tmp/data-993a1.tar
> Failed to prepare guest environment
> Traceback (most recent call last):
>   File "/home/peter.maydell/qemu-openbsd/tests/vm/basevm.py", line 654, in main
>     vm.add_source_dir(args.build_qemu)
>   File "/home/peter.maydell/qemu-openbsd/tests/vm/basevm.py", line
> 277, in add_source_dir
>     subprocess.check_call(["./scripts/archive-source.sh", tarfile],
>   File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command
> '['./scripts/archive-source.sh',
> '/home/peter.maydell/qemu-openbsd/build/vm-test-w7gx56ds.tmp/data-993a1.tar']'
> returned non-zero exit status 1.
> make: *** [/home/peter.maydell/qemu-openbsd/tests/vm/Makefile.include:110:
> vm-build-openbsd] Error 2
> make: Leaving directory '/home/peter.maydell/qemu-openbsd/build'

Deleting the whole subprojects/unicode-ident-1-rs/ subdirectory
seems to have fixed this -- it then realised it needed to
do the download and put it in the right place. I guess that was a
leftover from trying to build the previous version of the pullreq.
But it suggests that something is missing in the dependencies,
since it thought it had already downloaded it even though
the directory it needed to put it in wasn't on disk...

thanks
-- PMM