From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1R3nDo-0000ID-9r
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 07:01:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1R3nDi-0004AV-9E
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 07:01:40 -0400
MIME-Version: 1.0
In-Reply-To: <1315989802-18753-51-git-send-email-agraf@suse.de>
References: <1315989802-18753-1-git-send-email-agraf@suse.de>
	<1315989802-18753-51-git-send-email-agraf@suse.de>
Date: Wed, 14 Sep 2011 12:01:32 +0100
Message-ID: <CAFEAcA9w-4R3PqNVq8hL3rLn-kC-SLpyvApCsMYCmkKmEpr2yQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 50/58] pseries: Update SLOF firmware image
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-ppc@nongnu.org, qemu-devel Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, David Gibson <david@gibson.dropbear.id.au>

On 14 September 2011 09:43, Alexander Graf <agraf@suse.de> wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
>
> The current SLOF firmware for the pseries machine has a bug in SCSI
> condition handling that was exposed by recent updates to qemu's SCSI
> emulation. =C2=A0This patch updates the SLOF image to one with the bug fi=
xed.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> =C2=A0pc-bios/README =C2=A0 | =C2=A0 =C2=A02 +-
> =C2=A0pc-bios/slof.bin | =C2=A0Bin 579072 -> 578888 bytes
> =C2=A02 files changed, 1 insertions(+), 1 deletions(-)

I confess to not really understanding how we keep the git
submodules and the binary blobs in sync, but shouldn't there
be a reference in the commit message to the git commit hash
for the slof sources corresponding to this blob, and maybe
also an update to roms/SLOF here? (cf commit d67c3f2c for
example) ?

-- PMM