From: Peter Maydell <peter.maydell@linaro.org>
To: David Engraf <david.engraf@sysgo.com>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix non-secure flash mode
Date: Fri, 12 Jul 2019 16:34:46 +0100 [thread overview]
Message-ID: <CAFEAcA9xon6RmoUA=r5XLeVsYrVTub8F_gJsYcWJavaRX7Fosg@mail.gmail.com> (raw)
In-Reply-To: <20190712075002.14326-1-david.engraf@sysgo.com>
On Fri, 12 Jul 2019 at 08:53, David Engraf <david.engraf@sysgo.com> wrote:
>
> Using the whole 128 MiB flash in non-secure mode is not working because
> virt_flash_fdt() expects the same address for secure_sysmem and sysmem.
> This is not correctly handled by caller because it forwards NULL for
> secure_sysmem in non-secure flash mode.
>
> Fixed by using sysmem when secure_sysmem is NULL.
>
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
Nice catch; applied to target-arm.next for 4.1.
thanks
-- PMM
prev parent reply other threads:[~2019-07-12 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 7:50 [Qemu-devel] [PATCH] hw/arm/virt: Fix non-secure flash mode David Engraf
2019-07-12 15:34 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9xon6RmoUA=r5XLeVsYrVTub8F_gJsYcWJavaRX7Fosg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=david.engraf@sysgo.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).