From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y4Rhc-0003EU-NC
	for qemu-devel@nongnu.org; Fri, 26 Dec 2014 05:01:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y4RhY-0003tS-CL
	for qemu-devel@nongnu.org; Fri, 26 Dec 2014 05:01:00 -0500
Received: from mail-lb0-f180.google.com ([209.85.217.180]:49977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y4RhY-0003tI-67
	for qemu-devel@nongnu.org; Fri, 26 Dec 2014 05:00:56 -0500
Received: by mail-lb0-f180.google.com with SMTP id l4so8496589lbv.11
	for <qemu-devel@nongnu.org>; Fri, 26 Dec 2014 02:00:55 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1419581126-12927-1-git-send-email-tiejun.chen@intel.com>
References: <1419581126-12927-1-git-send-email-tiejun.chen@intel.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 26 Dec 2014 10:00:34 +0000
Message-ID: <CAFEAcA9yR2FPUF-T_ehMS4Yd0SL91mVADYwhDAuxCbkhQnNZiA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] kvm_irqchip_assign_irqfd: just set irqfd
 in case of kvm_irqfds_enabled()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>

On 26 December 2014 at 08:05, Tiejun Chen <tiejun.chen@intel.com> wrote:
> We should avoid to set irqfd{} unconditionally.
>
> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>

Is there a hot path that we use this on such that the difference
in code order matters at all?

thanks
-- PMM