From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiPMW-0002PE-P0 for qemu-devel@nongnu.org; Tue, 22 Mar 2016 12:41:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiPMR-0007Ix-5H for qemu-devel@nongnu.org; Tue, 22 Mar 2016 12:40:56 -0400 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:34500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiPMQ-0007IR-SO for qemu-devel@nongnu.org; Tue, 22 Mar 2016 12:40:50 -0400 Received: by mail-vk0-x22d.google.com with SMTP id e185so261538198vkb.1 for ; Tue, 22 Mar 2016 09:40:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1458593043-31731-1-git-send-email-armbru@redhat.com> References: <1458593043-31731-1-git-send-email-armbru@redhat.com> From: Peter Maydell Date: Tue, 22 Mar 2016 16:40:31 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: QEMU Developers On 21 March 2016 at 20:43, Markus Armbruster wrote: > Major issues addressed by this series: > > * The specification document is incomplete and vague. Rewritten. > > * When a peer goes away, and its ID gets reused for another one, > interrupts don't work. > > * When configured for interrupts, we receive shared memory from the > server some time after realize(). This creates a (usually > short-lived) "no shared memory, yet" state. If the guest wins the > race, it is exposed to this state (known issue, if you count burying > in docs/specs/ as "known"). If migration wins the race, it fails or > corrupts memory. > > * Interrupts are unreliable in a (usually small) time window after the > destination peer connects. I believe fixing this will require > changing the client/server protocol, so just document it for now. > > * The device isn't capable to tell guest software whether it is > configured for interrupts. Fix that in a new, backwards-compatible > revision of the guest ABI, and bump the PCI revision. Deprecate the > old revision. > > * The device properties are a confusing mess and badly checked. > Clean that up. > > * Migration with interrupts relies on server behavior not guaranteed > by the specification. Tighten the specification. > > v2: > * PATCH 05: Include ivshmem-test only in configurations that include > the device > * PATCH 36: Fix ivshmem-plain not to assert its nonexistent INTx Hi -- this appears to be missing the git URL to pull from? thanks -- PMM