From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Olaf Hering <olaf@aepfle.de>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build
Date: Fri, 28 Jul 2017 22:00:49 +0100 [thread overview]
Message-ID: <CAFEAcA_+ELUt-aeeQv6yUXqFXcBb1RbXmvhPMBzW+meahD+pig@mail.gmail.com> (raw)
In-Reply-To: <a965a76e-3a63-e69c-18f1-dbfdc569cafd@amsat.org>
On 28 July 2017 at 21:49, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Olaf,
>
> On 07/28/2017 10:11 AM, Olaf Hering wrote:
>>
>> g_malloc0_n is available since glib-2.24. To allow build with older glib
>> versions use the generic g_new0, which is already used in many other
>> places in the code.
>
>
> Can you provide information about which distrib/release/version/[packages?]
> you used? So we might add the same setup in QEMU continuous integration
> system.
I do have a build system with our oldest supported glib
version (it's my OSX box), and I have a feeling one of the
patchew centos configs does this too, but I guess neither
of them have the Xen headers to enable the Xen code,
which is why this one slipped through.
thanks
-- PMM
next prev parent reply other threads:[~2017-07-28 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:11 [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build Olaf Hering
2017-07-28 19:19 ` Eric Blake
2017-07-28 20:49 ` Philippe Mathieu-Daudé
2017-07-28 21:00 ` Peter Maydell [this message]
2017-07-28 22:29 ` Stefano Stabellini
2017-07-28 22:32 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_+ELUt-aeeQv6yUXqFXcBb1RbXmvhPMBzW+meahD+pig@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).