From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Nathan Egge <negge@xiph.org>,
Richard Henderson <richard.henderson@linaro.org>,
Akihiko Odaki <akihiko.odaki@daynix.com>,
Helge Deller <deller@gmx.de>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] Fix scripts/checkpatch.py style failures.
Date: Mon, 7 Aug 2023 10:24:46 +0100 [thread overview]
Message-ID: <CAFEAcA_+MMHsRPPp46Ho04gsQAoraW1DYP1GvYwaw3An010mKg@mail.gmail.com> (raw)
In-Reply-To: <848a140d-3855-8789-ff90-35952962651b@tls.msk.ru>
On Sat, 5 Aug 2023 at 17:44, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 05.08.2023 15:51, Nathan Egge пишет:
> > From: "Nathan Egge" <negge@xiph.org>
> >
> > Signed-off-by: Nathan Egge <negge@xiph.org>
>
> This needs at least some meaningful subject prefix.
> With the subject like it is now, it feels like the
> patch is about fixing checkpatch.py script itself.
>
> Something like:
>
> linux-user/syscall.c: fix coding-style issue (space-around-or)
>
> I think one of the two places should be fixed in a
> patch which touches this place in tcg-next series
> instead of separately.
Also, this specific area of code (brk handling) is currently
being worked on quite heavily. I'm pretty sure there's a patchset
on list which touches these specific lines of code (and might
well have fixed the style issue in passing). So we should hold
off on the purely coding-style fixes here until after the dust
has settled on those changes.
thanks
-- PMM
prev parent reply other threads:[~2023-08-07 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 12:51 [PATCH] Fix scripts/checkpatch.py style failures Nathan Egge
2023-08-05 13:31 ` Michael Tokarev
2023-08-05 16:43 ` Michael Tokarev
2023-08-07 9:24 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_+MMHsRPPp46Ho04gsQAoraW1DYP1GvYwaw3An010mKg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=deller@gmx.de \
--cc=mjt@tls.msk.ru \
--cc=negge@xiph.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).