qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)
Date: Thu, 18 Apr 2013 10:54:57 +0100	[thread overview]
Message-ID: <CAFEAcA_-OaB6wwYSx65FpBsnMuEuNW297qQt-_xzcme1nM82Hw@mail.gmail.com> (raw)
In-Reply-To: <516FBFAA.1060703@msgid.tls.msk.ru>

On 18 April 2013 10:40, Michael Tokarev <mjt@tls.msk.ru> wrote:
> The error in $subject is spewed when trying to compile current
> qemu code on my debian wheezy system.
>
> /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL*
> constants.  libusb-1.0-0 on my system is of version 1.0.11.
>
> Should we define some minimum libusb-1.0 version requiriment, or
> conditionally compile the 'loglevel' property?  Which minimum
> version is needed?

I think it would be sufficient for QEMU to use a hardcoded '2'
rather than the symbolic constant -- AFAICT older libusb
provides the functions for setting log level and the same set
of options, it just doesn't provide an enum for them.

(In particular we already rely on the integer values having
well defined and stable meanings across different libusb
versions, because we're exposing access to them to the user
via a pure integer property...)

-- PMM

  reply	other threads:[~2013-04-18  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18  9:40 [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function) Michael Tokarev
2013-04-18  9:54 ` Peter Maydell [this message]
2013-04-18  9:56 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_-OaB6wwYSx65FpBsnMuEuNW297qQt-_xzcme1nM82Hw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).