From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1USlYn-0003M8-Ng
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:55:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1USlYm-0002Ki-0W
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:55:21 -0400
Received: from mail-lb0-f174.google.com ([209.85.217.174]:46348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1USlYl-0002Ke-Q1
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:55:19 -0400
Received: by mail-lb0-f174.google.com with SMTP id s10so2465210lbi.5
	for <qemu-devel@nongnu.org>; Thu, 18 Apr 2013 02:55:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <516FBFAA.1060703@msgid.tls.msk.ru>
References: <516FBFAA.1060703@msgid.tls.msk.ru>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 18 Apr 2013 10:54:57 +0100
Message-ID: <CAFEAcA_-OaB6wwYSx65FpBsnMuEuNW297qQt-_xzcme1nM82Hw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel]
	=?utf-8?q?hw/usb/host-libusb=2Ec=3A1254=3A217=3A_err?=
	=?utf-8?b?b3I6IOKAmExJQlVTQl9MT0dfTEVWRUxfV0FSTklOR+KAmSB1bmRlY2xh?=
	=?utf-8?q?red_here_=28not_in_a_function=29?=
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 18 April 2013 10:40, Michael Tokarev <mjt@tls.msk.ru> wrote:
> The error in $subject is spewed when trying to compile current
> qemu code on my debian wheezy system.
>
> /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL*
> constants.  libusb-1.0-0 on my system is of version 1.0.11.
>
> Should we define some minimum libusb-1.0 version requiriment, or
> conditionally compile the 'loglevel' property?  Which minimum
> version is needed?

I think it would be sufficient for QEMU to use a hardcoded '2'
rather than the symbolic constant -- AFAICT older libusb
provides the functions for setting log level and the same set
of options, it just doesn't provide an enum for them.

(In particular we already rely on the integer values having
well defined and stable meanings across different libusb
versions, because we're exposing access to them to the user
via a pure integer property...)

-- PMM