From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ao6uc-00029i-F1
	for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:11:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ao6ub-00045i-JN
	for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:11:42 -0400
Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:33370)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ao6ub-00044R-By
	for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:11:41 -0400
Received: by mail-vk0-x230.google.com with SMTP id k1so92710685vkb.0
	for <qemu-devel@nongnu.org>; Thu, 07 Apr 2016 03:11:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1460023087-31509-3-git-send-email-vijayak@caviumnetworks.com>
References: <1460023087-31509-1-git-send-email-vijayak@caviumnetworks.com>
	<1460023087-31509-3-git-send-email-vijayak@caviumnetworks.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 7 Apr 2016 11:11:21 +0100
Message-ID: <CAFEAcA_0ssT32oNrgTHChKsAJNkjUfCHFGg2vPtk8-AWsRjVqw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to
	fetch /proc/cpuinfo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vijaya Kumar K <vijayak@caviumnetworks.com>
Cc: Vijay Kilari <vijay.kilari@gmail.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, knv.suresh2009@gmail.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, QEMU Developers <qemu-devel@nongnu.org>, qemu-arm <qemu-arm@nongnu.org>, Suresh <ksuresh@caviumnetworks.com>, Paolo Bonzini <pbonzini@redhat.com>

On 7 April 2016 at 10:58,  <vijayak@caviumnetworks.com> wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>
> utils cannot read target cpu information to
> fetch cpu information to implement cpu specific
> features or erratas. For this parse /proc/cpuinfo
> and fetch cpu information.
>
> For now this helper only fetches cpu information
> for arm architectures.

As I understand it /proc/cpuinfo is intended only for
humans to read. Please don't write code to parse it;
find a different way to get this information instead
if you really need it.

(I'm not really happy about such specific-to-a-particular-vendor
patches in QEMU anyway; we should have migration code that
works acceptably for any implementation.)

thanks
-- PMM