Re: [PATCH 2/2] log: Suggest using -d guest_error,memaccess instead of guest_errors

[Peter Maydell <peter.maydell@linaro.org>]

On Sun, 6 Oct 2024 at 17:49, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> Rename guest_errors to guest_error to match the log constant

I don't think this is a good reason to change the user-facing
behaviour. Also, I don't think the existing names are so bad:

 -d guest_errors
   this is plural because we are asking to log all guest errors
 qemu_log_mask(LOG_GUEST_ERROR, ...)
   this is singular because we are logging a single error here.

If we do want to change things for consistency, we should decide
on what the user-facing option name ought to be (and I think
plural is fine), and then change the internal define to match
that, not vice versa.

> and print
> a warning for -d guest_errors to remind using guest_error,memaccess
> instead but preserve previous behaviour for convenience.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

thanks
-- PMM