From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
QEMU Developers <qemu-devel@nongnu.org>,
Subbaraya Sundeep <sundeep.lkml@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/msf2-som: Exit when the cpu is not the expected one
Date: Mon, 1 Jul 2019 12:14:51 +0100 [thread overview]
Message-ID: <CAFEAcA_2QkVDGaVUtn_8ofHcfuj9Zg0RMq4a_YcGKmmFJCu5zQ@mail.gmail.com> (raw)
In-Reply-To: <20190617160136.29930-1-philmd@redhat.com>
On Mon, 17 Jun 2019 at 17:01, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> This machine correctly defines its default_cpu_type to cortex-m3
> and report an error if the user requested another cpu_type,
> however it does not exit, and this can confuse users trying
> to use another core:
>
> $ qemu-system-arm -M emcraft-sf2 -cpu cortex-m4 -kernel test-m4.elf
> qemu-system-arm: This board can only be used with CPU cortex-m3-arm-cpu
> [output related to M3 core ...]
>
> The CPU is indeed a M3 core:
>
> (qemu) info qom-tree
> /machine (emcraft-sf2-machine)
> /unattached (container)
> /device[0] (msf2-soc)
> /armv7m (armv7m)
> /cpu (cortex-m3-arm-cpu)
>
> Add the missing exit() call to return to the shell.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2019-07-01 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 16:01 [Qemu-devel] [PATCH] hw/arm/msf2-som: Exit when the cpu is not the expected one Philippe Mathieu-Daudé
2019-06-17 17:15 ` Alistair Francis
2019-06-17 17:20 ` Eduardo Habkost
2019-07-01 11:14 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_2QkVDGaVUtn_8ofHcfuj9Zg0RMq4a_YcGKmmFJCu5zQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair@alistair23.me \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).