Re: [PATCH qemu 1/3] target/arm: Unify checking for M Main Extension in MRS/MSR

[Peter Maydell <peter.maydell@linaro.org>]

On Mon, 9 Jan 2023 at 23:18, ~dreiss-meta <dreiss-meta@git.sr.ht> wrote:
>
> From: David Reiss <dreiss@meta.com>
>
> BASEPRI, FAULTMASK, and their _NS equivalents only exist on devices with
> the Main Extension.  However, the MRS instruction did not check this,
> and the MSR instruction handled it inconsistently (warning BASEPRI, but
> silently ignoring writes to BASEPRI_NS).  Unify this behavior and always
> warn when reading or writing any of these registers if the extension is
> not present.
>
> Signed-off-by: David Reiss <dreiss@meta.com>
> ---

Hi; it looks like you didn't send a cover letter for this patchset.
If you're making contributions in future, if you could send a cover
letter for a multi-patch submission, that's helpful because our
automated tooling tends to get confused by patchsets which don't
have one. (A single standalone patch doesn't need a cover letter.)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM