From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: Wei Huang <wei@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhao@linaro.org>,
Andrea Bolognani <abologna@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support
Date: Fri, 29 Jul 2016 16:29:03 +0100 [thread overview]
Message-ID: <CAFEAcA_58ffJV+YXn1xA_RDpgBnPRLDf9PTGif0KuCkRet47OA@mail.gmail.com> (raw)
In-Reply-To: <20160729065453.qq44y2hxohizk3yw@hawk.localdomain>
On 29 July 2016 at 07:54, Andrew Jones <drjones@redhat.com> wrote:
> OK, so this property will be exposed to all ARM cpu types, and if a user
> turns it on, then it will stay on for all types, except when using KVM
> with an aarch64 cpu type, and KVM doesn't support it. This could mislead
> users to believe they'll get a pmu, by simply adding pmu=on, even when
> they can't. I think we'd ideally keep has_pmu, and the current code that
> sets it, and then add code like
>
> if (enable_pmu && !has_pmu) {
> error_report("Warning: ...")
> }
>
> somewhere.
I think we should probably follow the existing model used by
has_el3, where the property only exists if it's valid to set it.
thanks
-- PMM
next prev parent reply other threads:[~2016-07-29 15:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 16:38 [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support Wei Huang
2016-07-29 0:59 ` Shannon Zhao
2016-07-29 6:54 ` Andrew Jones
2016-07-29 15:07 ` Wei Huang
2016-07-29 15:29 ` Peter Maydell [this message]
2016-08-01 12:04 ` Andrea Bolognani
2016-08-01 13:08 ` Andrew Jones
2016-08-01 13:16 ` Peter Maydell
2016-08-01 13:26 ` Andrea Bolognani
2016-08-01 13:32 ` Peter Maydell
2016-08-01 14:55 ` Andrea Bolognani
2016-08-13 6:06 ` Wei Huang
2016-08-15 9:24 ` Andrea Bolognani
2016-07-29 7:57 ` Peter Maydell
2016-07-29 15:08 ` Wei Huang
2016-07-29 15:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_58ffJV+YXn1xA_RDpgBnPRLDf9PTGif0KuCkRet47OA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=abologna@redhat.com \
--cc=drjones@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).