From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52541)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W3jfv-0006Tr-U2
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:55:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W3jfp-0008J3-DN
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:55:47 -0500
Received: from mail-la0-f41.google.com ([209.85.215.41]:37637)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W3jfp-0008Ih-7S
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:55:41 -0500
Received: by mail-la0-f41.google.com with SMTP id mc6so2371588lab.28
	for <qemu-devel@nongnu.org>; Thu, 16 Jan 2014 01:55:38 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <52D79A98.7050400@redhat.com>
References: <1389806638-3114-1-git-send-email-peter.maydell@linaro.org>
	<52D7065F.9020203@redhat.com>
	<CAFEAcA_6T_rB5A1Z2wtK5YHPw1CSVeG+p2uQsxX5F-+4BFjBzg@mail.gmail.com>
	<52D79A98.7050400@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 16 Jan 2014 09:55:18 +0000
Message-ID: <CAFEAcA_5H90XWvyMZU_aDqTOXXWSXoYdxf=1Osb-015PQX-sbA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer
	callback interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-stable <qemu-stable@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Patch Tracking <patches@linaro.org>

On 16 January 2014 08:38, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 15/01/2014 23:15, Peter Maydell ha scritto:
>>
>>> > +    curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running);
>> The libcurl docs say "This function was added in libcurl 7.15.4, and
>>  is deemed stable since 7.16.0. " So if we want to keep supporting
>> pre-7.16 libcurl then we need to retain the multi_socket_all codepath.
>>
>> On the other hand 7.16 was released in October 2006. What's
>> the oldest version we actually care about?
>
> I say 7.16 :)

What dos RHEL5 ship? That's usually our benchmark for
"oldest thing we need to support". Ubuntu 10.04 LTS (lucid)
and Debian oldstable (squeeze) both ship something more
recent than 7.16, so we're OK there.

We should probably update the configure test to check for
curl_multi_socket_action() rather than curl_multi_setopt().

thanks
-- PMM