From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h
Date: Mon, 24 Jul 2017 13:21:15 +0100 [thread overview]
Message-ID: <CAFEAcA_5n8KcphyOMadVUdJhexXO+idHU+dk3kv4egQPbu8Cxg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-m60XQOGJApVeezS1RUxdd=iTzPt=L2eqGpwqBEjNYUA@mail.gmail.com>
On 24 July 2017 at 11:40, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 July 2017 at 05:40, Richard Henderson <rth@twiddle.net> wrote:
>> Clang 3.9 passes the CONFIG_AVX2_OPT configure test. However, the
>> supplied <cpuid.h> does not contain the bit_AVX2 define that we use
>> when detecting whether the routine can be enabled.
>>
>> Introduce a qemu-specific header that uses the compiler's definition
>> of __cpuid et al, but supplies any missing bit_* definitions needed.
>> This avoids introducing any extra ifdefs to util/bufferiszero.c, and
>> allows quite a few to be removed from tcg/i386/tcg-target.inc.c.
>>
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>
>> Peter, this is the clang 3.9 problem I mentioned the other day,
>> when attempting to reproduce the other clang 3.8 problem.
>>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
...and applied to master as a buildfix for clang 3.9.
thanks
-- PMM
prev parent reply other threads:[~2017-07-24 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 4:40 [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h Richard Henderson
2017-07-24 10:40 ` Peter Maydell
2017-07-24 12:21 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_5n8KcphyOMadVUdJhexXO+idHU+dk3kv4egQPbu8Cxg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).