From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WPj-0000vf-6u for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9WPf-0000IJ-NI for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:35:47 -0400 Received: from mail-vn0-f53.google.com ([209.85.216.53]:44301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WPf-0000IA-Jh for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:35:43 -0400 Received: by vnbf1 with SMTP id f1so10213117vnb.11 for ; Mon, 29 Jun 2015 03:35:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> From: Peter Maydell Date: Mon, 29 Jun 2015 11:35:23 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, Alexander Graf , Thomas Huth , Markus Armbruster , QEMU Developers , Luiz Capitulino , "qemu-ppc@nongnu.org" , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 29 June 2015 at 06:36, David Gibson wrote: > At present, the core device model code for 8250-like serial ports > (serial.c) and the code for serial ports attached to ISA-style legacy IO > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > There are lots and lots of embedded platforms that have 8250-like serial > ports but have never had anything resembling ISA legacy IO. Therefore, > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > disabled for platforms where it's not appropriate. > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those > platforms have technically lost functionality, but since they have no > other PCI or ISA devices, it's fairly clear they never actually used > leagacy IO stuff. s/leagacy/legacy/ Is it worth having a default-configs/isa.mak along the lines of our current pci.mak and usb.mak, for putting CONFIG_ defines for all ISA devices? A quick grep suggests you can knock arm, moxie, sh4 and sh4eb off your list of things with CONFIG_SERIAL_ISA (no hits for ISABus). I notice in passing that we still have a handful of config files which set CONFIG_ISA_MMIO, despite that having been deleted in commit 61fcb628627ea4 two years ago. thanks -- PMM