From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlm2Z-0005dy-JA for qemu-devel@nongnu.org; Tue, 26 Jul 2011 14:07:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlm2Y-000725-1y for qemu-devel@nongnu.org; Tue, 26 Jul 2011 14:07:35 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:50683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlm2X-00071p-TT for qemu-devel@nongnu.org; Tue, 26 Jul 2011 14:07:34 -0400 Received: by gyg8 with SMTP id 8so541653gyg.4 for ; Tue, 26 Jul 2011 11:07:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1310144181-22901-1-git-send-email-peter.maydell@linaro.org> References: <1310144181-22901-1-git-send-email-peter.maydell@linaro.org> Date: Tue, 26 Jul 2011 19:07:32 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/4] omap_gpio: convert to qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , =?UTF-8?Q?Juha_Riihim=C3=A4ki?= , Markus Armbruster , patches@linaro.org Ping? (added back the CCs that qemu-devel seems to have stripped out...) On 8 July 2011 17:56, Peter Maydell wrote: > These patches are changes from the meego omap3 tree which convert > the omap GPIO module device to use qdev. > > Changes v1->v2: > =C2=A0* renamed omap_l4_base() to omap_l4_region_base() > =C2=A0* provide two qdev devices 'omap-gpio' and 'omap2-gpio' rather than > =C2=A0 trying to shoehorn two significantly different devices into one > =C2=A0 (and use hyphen rather than underscore in the device name) > =C2=A0* wire up the omap clocks to the gpio modules as qdev properties > =C2=A0 (including adding a missing omap2 clock definition...) > > We use qdev pointer properties for the omap clocks. This is not ideal. > My preference would be for qdev to support a generic means of defining > a 'port' with an arbitrary interface for connecting two devices. Then > we could reframe the omap clock API in terms of clock ports, and get > some type safety. For now passing an arbitrary pointer seems like the > best pragmatic interim solution. (It's not possible to pass in the > string which is the clock name, because the device does not have the > necessary information (ie the struct omap_mpu_state_s*) to do the > clockname to pointer translation.) > > Juha Riihim=C3=A4ki (2): > =C2=A0hw/omap_l4.c: Add helper function omap_l4_region_base > =C2=A0hw/omap_gpio.c: Convert to qdev > > Peter Maydell (2): > =C2=A0hw/omap_gpio.c: Don't complain about some writes to r/o registers > =C2=A0hw/omap_clk: Add the clock for the OMAP2430-specific fifth GPIO > =C2=A0 =C2=A0module > > =C2=A0hw/nseries.c =C2=A0 | =C2=A0 47 +++++----- > =C2=A0hw/omap.h =C2=A0 =C2=A0 =C2=A0| =C2=A0 22 +---- > =C2=A0hw/omap1.c =C2=A0 =C2=A0 | =C2=A0 10 ++- > =C2=A0hw/omap2.c =C2=A0 =C2=A0 | =C2=A0 34 ++++++-- > =C2=A0hw/omap_clk.c =C2=A0| =C2=A0 =C2=A06 +- > =C2=A0hw/omap_gpio.c | =C2=A0263 ++++++++++++++++++++++++++++++++--------= --------------- > =C2=A0hw/omap_l4.c =C2=A0 | =C2=A0 =C2=A06 ++ > =C2=A0hw/palm.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 26 +++--- > =C2=A08 files changed, 235 insertions(+), 179 deletions(-)