From: Peter Maydell <peter.maydell@linaro.org>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Wei Huang <wei@redhat.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhao@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button
Date: Wed, 23 Mar 2016 16:12:46 +0000 [thread overview]
Message-ID: <CAFEAcA_7ww3PBQ5Mf=ax69B2i6zOx4-pDaiEUVerGG5iru-pJg@mail.gmail.com> (raw)
In-Reply-To: <1458221140-15232-1-git-send-email-zhaoshenglong@huawei.com>
On 17 March 2016 at 13:25, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> There is a problem for power button that it will not work if an early
> system_powerdown request happens before guest gpio driver loads.
>
> Here we add the emulation of gpio_key and use it for ARM virt power
> button.
I tweaked the type names to be 'gpio-key' rather than 'gpio_key',
and added a comment to briefly describe what the device does:
+ * Emulate a (human) keypress -- when the key is triggered by
+ * setting the incoming gpio line, the outbound irq line is
+ * raised for 100ms before being dropped again.
Applied to target-arm.next, thanks.
-- PMM
next prev parent reply other threads:[~2016-03-23 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 13:25 [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button Shannon Zhao
2016-03-17 13:25 ` [Qemu-devel] [PATCH 1/2] hw/gpio: Add the emulation of gpio_key Shannon Zhao
2016-03-17 13:25 ` [Qemu-devel] [PATCH 2/2] ARM: Virt: Use gpio_key for power button Shannon Zhao
2016-03-23 16:12 ` Peter Maydell [this message]
2016-03-23 17:14 ` [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt " Wei Huang
2016-03-24 0:58 ` Shannon Zhao
2016-04-06 17:50 ` Emilio G. Cota
2016-04-06 19:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_7ww3PBQ5Mf=ax69B2i6zOx4-pDaiEUVerGG5iru-pJg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).