From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ailPD-00025q-VP
	for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:13:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ailPA-0006ot-30
	for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:13:11 -0400
Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:33367)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ailP9-0006oT-Ur
	for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:13:08 -0400
Received: by mail-vk0-x22e.google.com with SMTP id k1so25650168vkb.0
	for <qemu-devel@nongnu.org>; Wed, 23 Mar 2016 09:13:06 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1458221140-15232-1-git-send-email-zhaoshenglong@huawei.com>
References: <1458221140-15232-1-git-send-email-zhaoshenglong@huawei.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 23 Mar 2016 16:12:46 +0000
Message-ID: <CAFEAcA_7ww3PBQ5Mf=ax69B2i6zOx4-pDaiEUVerGG5iru-pJg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt
	power button
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Wei Huang <wei@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 17 March 2016 at 13:25, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> There is a problem for power button that it will not work if an early
> system_powerdown request happens before guest gpio driver loads.
>
> Here we add the emulation of gpio_key and use it for ARM virt power
> button.

I tweaked the type names to be 'gpio-key' rather than 'gpio_key',
and added a comment to briefly describe what the device does:

+ * Emulate a (human) keypress -- when the key is triggered by
+ * setting the incoming gpio line, the outbound irq line is
+ * raised for 100ms before being dropped again.

Applied to target-arm.next, thanks.

-- PMM