From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F5FC433F5 for ; Thu, 21 Apr 2022 10:58:26 +0000 (UTC) Received: from localhost ([::1]:56210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhUW2-00058s-3E for qemu-devel@archiver.kernel.org; Thu, 21 Apr 2022 06:58:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhUSY-0007m7-Hq for qemu-devel@nongnu.org; Thu, 21 Apr 2022 06:54:53 -0400 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]:38527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhUSW-0006lF-VH for qemu-devel@nongnu.org; Thu, 21 Apr 2022 06:54:50 -0400 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2ec0bb4b715so47782777b3.5 for ; Thu, 21 Apr 2022 03:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=660QUaqQvd4rcfLPMXi0b7zjAEPQZCxmC7BNlshr0sg=; b=tVvz85ds2650+YFjy1BKpupEpl/fHvYLq+/L7XnNIYMQg+iRGCu7/9hGMokIzQFAo5 L7BmpYerZKg6RHM24uMFK3Cq7AHYA9fU2WvW6UT5dxoNplfR9+mqgOxmH696dtglnfqo RBGQNoZn4r5YkBdtnxQYateyOSk8At/330kEyyxBx3oHO/92i5QtH1yJFQP1ZZVsTE+7 bSGZ3akaAkTQGfDGFbK5Yczq1kgC/ACCkifHmzQeML0OZfztpmyNsJK3lD+VxTghD+9E vKzTDi8iOGDMVkDYDhax6Xs7JBZfG5BVVOwRkLnEIeIqtqsE96yjtnYNqeYUovz16z3Y MRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=660QUaqQvd4rcfLPMXi0b7zjAEPQZCxmC7BNlshr0sg=; b=MB6RETkdoW1LPGj64wEoCwD0aAGDN0JxkeimqkSfdZ6Kw2gZq9nXXrTVAeR+TGRsdG FB0jQi6EisMIpOjxm//A3DfHiJO6N6wgGqZZ+QIR7Or1/0FlC7H4BEUgK2W43dKXuKAo IpczlJMrvRba7ZozhM4HbRZBrYdS3+1XYMUV10Yzq8Vw35wqyZpISMgelwjiiXsll9es MvDR/5KPjgW/SAowxamKyHGINo05UJ13e8DMNyJHbHCBO4v9ei3deV0fHjmOcWKc2VFX /30FBXqcoM+COIMNHbsBbu5+lOZblEx0/C4/9nbQEKWERl2YdPTgmFUJKPhF9jsbFe72 6FJg== X-Gm-Message-State: AOAM531Pdti2SWJ1WQIEeWaVmNBI9layeXyEAlLxLK7EeEsU8B838tQq VEJqjCNHlpUXNfKKuv24nv3P3L7XvmE3ilMaPWWz3Q== X-Google-Smtp-Source: ABdhPJz8ufhYIj59I+VeRyJoGucM/ZRFf+Nc8K5WshA+imctQztGorD0RZxiOAt9UqRclXRD+BF8bb+0mydtiVUDyMU= X-Received: by 2002:a81:4e11:0:b0:2f1:47a0:5972 with SMTP id c17-20020a814e11000000b002f147a05972mr26438071ywb.469.1650538487948; Thu, 21 Apr 2022 03:54:47 -0700 (PDT) MIME-Version: 1.0 References: <20220405223640.2595730-1-wuhaotsh@google.com> <20220405223640.2595730-5-wuhaotsh@google.com> In-Reply-To: <20220405223640.2595730-5-wuhaotsh@google.com> From: Peter Maydell Date: Thu, 21 Apr 2022 11:54:37 +0100 Message-ID: Subject: Re: [PATCH for-7.1 04/11] hw/misc: Support NPCM8XX CLK Module Registers To: Hao Wu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::112d; envelope-from=peter.maydell@linaro.org; helo=mail-yw1-x112d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Uri.Trichter@nuvoton.com, titusr@google.com, venture@google.com, hskinnemoen@google.com, qemu-devel@nongnu.org, kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com, Vishal.Soni@microsoft.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 Apr 2022 at 23:38, Hao Wu wrote: > > NPCM8XX adds a few new registers and have a different set of reset > values to the CLK modules. This patch supports them. > > This patch doesn't support the new clock values generated by these > registers. Currently no modules use these new clock values so they > are not necessary at this point. > Implementation of these clocks might be required when implementing > these modules. > > Signed-off-by: Hao Wu > Reviewed-by: Titus Rwantare Can you split this one up as well, please ? In particular keep the purely-mechanical changes (eg renaming structs) separate from actually-interesting ones. thanks -- PMM