From: Peter Maydell <peter.maydell@linaro.org>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState
Date: Wed, 26 Oct 2011 18:24:28 +0100 [thread overview]
Message-ID: <CAFEAcA_8mW4ALDb1rmBLcV2s4HPitXZeoPv0H-f3k36i5YhHjQ@mail.gmail.com> (raw)
In-Reply-To: <1319540983-4248-5-git-send-email-benoit.canet@gmail.com>
On 25 October 2011 12:09, Benoît Canet <benoit.canet@gmail.com> wrote:
> +static const VMStateDescription vmstate_integratorcm = {
> + .name = "integratorcm",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .minimum_version_id_old = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(memsz, integratorcm_state),
> + VMSTATE_BOOL(flash_mapped, integratorcm_state),
This raises a question. flash_mapped here is a flag which just
tracks whether the associated MemoryRegion is currently mapped
or unmapped. Do we need to do anything special to ensure that
the MemoryRegion itself is reset to the correct mapped/unmapped
state on restore?
I recall discussing this kind of thing with Avi on IRC but I
can't remember what the conclusion was.
-- PMM
next prev parent reply other threads:[~2011-10-26 17:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 11:09 [Qemu-devel] [PATCH 0/5] arm: VMState conversion Benoît Canet
2011-10-25 11:09 ` [Qemu-devel] [PATCH 1/5] pl181: add vmstate Benoît Canet
2011-10-25 11:09 ` [Qemu-devel] [PATCH 2/5] bitbang_i2c: convert to VMState Benoît Canet
2011-10-25 11:09 ` [Qemu-devel] [PATCH 3/5] realview: convert realview i2c " Benoît Canet
2011-10-25 11:09 ` [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm " Benoît Canet
2011-10-26 17:24 ` Peter Maydell [this message]
2011-11-08 2:07 ` Peter Maydell
2011-11-08 6:33 ` Avi Kivity
2011-11-08 10:08 ` Benoît Canet
2011-11-08 12:16 ` Peter Maydell
2011-11-08 12:15 ` Peter Maydell
2011-11-08 12:21 ` Avi Kivity
2011-11-08 12:30 ` Peter Maydell
2011-11-08 12:38 ` Avi Kivity
2011-11-08 12:47 ` Peter Maydell
2011-11-08 13:50 ` Anthony Liguori
2011-11-08 14:38 ` Avi Kivity
2011-11-08 15:04 ` Anthony Liguori
2011-11-08 15:15 ` Avi Kivity
2011-11-08 15:32 ` Anthony Liguori
2011-11-08 17:19 ` Avi Kivity
2011-11-09 14:40 ` Anthony Liguori
2011-11-09 15:05 ` Avi Kivity
2011-11-09 15:20 ` Peter Maydell
2011-11-09 15:21 ` Avi Kivity
2011-11-09 15:49 ` Anthony Liguori
2011-11-09 15:56 ` Avi Kivity
2011-11-09 16:07 ` Peter Maydell
2011-11-09 17:43 ` Anthony Liguori
2011-11-09 18:09 ` Avi Kivity
2011-10-25 11:09 ` [Qemu-devel] [PATCH 5/5] integratorcp: convert icp_pic " Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_8mW4ALDb1rmBLcV2s4HPitXZeoPv0H-f3k36i5YhHjQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).