From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Sebastian Ottlik <ottlik@fzi.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows
Date: Wed, 4 Sep 2013 15:41:45 +0100 [thread overview]
Message-ID: <CAFEAcA_9_X_V7uzMGtuHMBLpsDwHvrA+zWS5VJvDbEm3oAtB=g@mail.gmail.com> (raw)
In-Reply-To: <52274357.6010509@redhat.com>
On 4 September 2013 15:27, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 04/09/2013 16:22, Sebastian Ottlik ha scritto:
>> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems
>> the default behavior is equivalent to SO_REUSEADDR on other operating
>> systems. SO_REUSEADDR can still be set but results in undesired bahvior
>> instead. It may even lead to situations were system behavior is
>> unspecified. More information on this can be found at:
>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx
Yep. The issue's come up before:
https://lists.nongnu.org/archive/html/qemu-devel/2011-03/msg01794.html
but I guess nobody ever got round to writing the patch.
> Can you make a different patch that introduces a new function
> qemu_set_reuseaddr is include/qemu/sockets.h & util/oslib-*, and makes
> it a stub for Windows?
Yes please, and include a comment in the Windows stub
explaining why it does nothing (with the links to MSDN docs)
because otherwise it's pretty unobvious and an invitation
for somebody to incorrectly reinstate the brokenness.
-- PMM
next prev parent reply other threads:[~2013-09-04 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 14:22 [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows Sebastian Ottlik
2013-09-04 14:22 ` [Qemu-devel] [PATCH RFC 1/4] gdbstub: do " Sebastian Ottlik
2013-09-04 14:22 ` [Qemu-devel] [PATCH RFC 2/4] net: " Sebastian Ottlik
2013-09-04 14:22 ` [Qemu-devel] [PATCH RFC 3/4] slirp: " Sebastian Ottlik
2013-09-04 14:22 ` [Qemu-devel] [PATCH RFC 4/4] util: " Sebastian Ottlik
2013-09-04 14:27 ` [Qemu-devel] [PATCH RFC] Do " Paolo Bonzini
2013-09-04 14:34 ` Jan Kiszka
2013-09-05 7:36 ` Michael Tokarev
2013-09-04 14:35 ` Sebastian Ottlik
2013-09-04 14:41 ` Peter Maydell [this message]
2013-09-04 17:31 ` Stefan Weil
2013-09-04 17:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_9_X_V7uzMGtuHMBLpsDwHvrA+zWS5VJvDbEm3oAtB=g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=ottlik@fzi.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).