qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Sergey Kambalin <serg.oker@gmail.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	 Sergey Kambalin <sergey.kambalin@auriga.com>
Subject: Re: [PATCH 20/44] Implement BCM2838 thermal sensor
Date: Fri, 4 Aug 2023 15:38:40 +0100	[thread overview]
Message-ID: <CAFEAcA_AkwcWaDWeewzB7OVzmKH-Cc5n7G8oipnYRayqKd3ndA@mail.gmail.com> (raw)
In-Reply-To: <20230726132512.149618-21-sergey.kambalin@auriga.com>

On Wed, 26 Jul 2023 at 14:48, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>  hw/arm/bcm2838_peripherals.c         | 12 ++++
>  hw/arm/raspi4b.c                     |  1 -
>  hw/misc/bcm2838_thermal.c            | 96 ++++++++++++++++++++++++++++
>  hw/misc/meson.build                  |  3 +-
>  include/hw/arm/bcm2838_peripherals.h |  2 +
>  include/hw/misc/bcm2838_thermal.h    | 24 +++++++
>  6 files changed, 136 insertions(+), 2 deletions(-)
>  create mode 100644 hw/misc/bcm2838_thermal.c
>  create mode 100644 include/hw/misc/bcm2838_thermal.h
>
> diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c
> index df97953bbe..e7a9db97ab 100644
> --- a/hw/arm/bcm2838_peripherals.c
> +++ b/hw/arm/bcm2838_peripherals.c
> @@ -37,6 +37,9 @@ static void bcm2838_peripherals_init(Object *obj)
>      /* Random Number Generator */
>      object_initialize_child(obj, "rng200", &s->rng200, TYPE_BCM2838_RNG200);
>
> +    /* Thermal */
> +    object_initialize_child(obj, "thermal", &s->thermal, TYPE_BCM2838_THERMAL);
> +
>      /* PCIe Host Bridge */
>      object_initialize_child(obj, "pcie-host", &s->pcie_host,
>                              TYPE_BCM2838_PCIE_HOST);
> @@ -98,6 +101,14 @@ static void bcm2838_peripherals_realize(DeviceState *dev, Error **errp)
>          qdev_get_gpio_in_named(DEVICE(&s_base->ic), BCM2835_IC_GPU_IRQ,
>                                 INTERRUPT_RNG));
>
> +    /* THERMAL */
> +    if (!sysbus_realize(SYS_BUS_DEVICE(&s->thermal), errp)) {
> +        return;
> +    }
> +    memory_region_add_subregion(
> +        &s->peri_low_mr, 0x15D2000,
> +        sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->thermal), 0));

(more odd indentation here)

> +
>      /* Extended Mass Media Controller 2 */
>      object_property_set_uint(OBJECT(&s->emmc2), "sd-spec-version", 3,
>                               &error_abort);
> @@ -197,6 +208,7 @@ static void bcm2838_peripherals_realize(DeviceState *dev, Error **errp)
>                               BCM2838_MPHI_SIZE);
>      memory_region_add_subregion(&s_base->peri_mr, BCM2838_MPHI_OFFSET,
>                                  &s->mphi_mr_alias);
> +
>      /* PCIe Root Complex */
>      if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie_host), errp)) {
>          return;
> diff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c
> index 82b6b48d3c..c7fdf791d5 100644
> --- a/hw/arm/raspi4b.c
> +++ b/hw/arm/raspi4b.c
> @@ -66,7 +66,6 @@ static void raspi4_modify_dtb(const struct arm_boot_info *info, void *fdt)
>
>      /* Temporary disable following devices until they are implemented*/
>      const char *to_be_removed_from_dt_as_wa[] = {
> -        "brcm,bcm2711-thermal",
>          "brcm,bcm2711-genet-v5",
>      };
>
> diff --git a/hw/misc/bcm2838_thermal.c b/hw/misc/bcm2838_thermal.c
> new file mode 100644
> index 0000000000..a488dc3da1
> --- /dev/null
> +++ b/hw/misc/bcm2838_thermal.c
> @@ -0,0 +1,96 @@
> +/*
> + * BCM2838 dummy thermal sensor
> + *
> + * Copyright (C) 2022 Maksim Kopusov <maksim.kopusov@auriga.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qemu/log.h"
> +#include "qapi/error.h"
> +#include "hw/misc/bcm2838_thermal.h"
> +#include "hw/registerfields.h"
> +#include "migration/vmstate.h"
> +#include "qemu/error-report.h"
> +
> +REG32(STAT, 0x200)
> +FIELD(STAT, DATA, 0, 10)
> +FIELD(STAT, VALID_1, 10, 1)
> +FIELD(STAT, VALID_2, 16, 1)
> +
> +#define BCM2838_THERMAL_SIZE 0xf00
> +
> +#define THERMAL_OFFSET_C 410040
> +#define THERMAL_COEFF  (-487.0f)
> +#define MILLIDEGREE_COEFF 1000
> +
> +static uint16_t bcm2838_thermal_temp2adc(int temp_C)
> +{
> +    return (temp_C * MILLIDEGREE_COEFF - THERMAL_OFFSET_C) / THERMAL_COEFF;
> +}
> +
> +static uint64_t bcm2838_thermal_read(void *opaque, hwaddr addr, unsigned size)
> +{
> +    uint32_t val = 0;
> +
> +    switch (addr) {
> +    case A_STAT:
> +        /* Temperature is always 25°C */
> +         val = FIELD_DP32(val, STAT, DATA, bcm2838_thermal_temp2adc(25));
> +         val = FIELD_DP32(val, STAT, VALID_1, 1);
> +         val = FIELD_DP32(val, STAT, VALID_2, 1);
> +
> +         break;
> +    default:
> +         /* MemoryRegionOps are aligned, so this can not happen. */

This comment doesn't seem right. BCM2838_THERMAL_SIZE is larger
than 4, so we can have more than one possible address accessed,
even if the address must be aligned. So the warning is
OK, but the g_assert_reached() and the comment are not.

> +         warn_report("%s can't access addr: 0x%"PRIx64,
> +                     TYPE_BCM2838_THERMAL, addr);

We usually use a LOG_GUEST_ERROR for this kind of "access
with an address that doesn't correspond to a register".

> +         g_assert_not_reached();
> +    }
> +    return val;
> +}
> +
> +static const MemoryRegionOps bcm2838_thermal_ops = {
> +    .read = bcm2838_thermal_read,

You need to provide a .write, even if it just does a
LOG_GUEST_ERROR for every access. Otherwise if the guest
tries to write then QEMU will crash trying to call the NULL
pointer.

> +    .impl.max_access_size = 4,
> +    .valid.min_access_size = 4,
> +    .endianness = DEVICE_NATIVE_ENDIAN,
> +};
> +
> +static void bcm2838_thermal_realize(DeviceState *dev, Error **errp)
> +{
> +    Bcm2838ThermalState *s = BCM2838_THERMAL(dev);
> +
> +    memory_region_init_io(&s->iomem, OBJECT(s), &bcm2838_thermal_ops,
> +                          s, TYPE_BCM2838_THERMAL, BCM2838_THERMAL_SIZE);
> +    sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem);
> +}
> +
> +static const VMStateDescription bcm2838_thermal_vmstate = {
> +    .name = TYPE_BCM2838_THERMAL,
> +    .version_id = 1,
> +    .minimum_version_id = 1,
> +};

You don't need to set up a vmstate if it has no data.

> +
> +static void bcm2838_thermal_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->realize = bcm2838_thermal_realize;
> +    dc->vmsd = &bcm2838_thermal_vmstate;

You can add a comment here:
 /* This device has no state: no need for vmstate or reset */

to tell the reader you haven't forgotten it.

> +}
> +
> +static const TypeInfo bcm2838_thermal_info = {
> +    .name = TYPE_BCM2838_THERMAL,
> +    .parent = TYPE_SYS_BUS_DEVICE,
> +    .instance_size = sizeof(Bcm2838ThermalState),
> +    .class_init = bcm2838_thermal_class_init,
> +};
> +
> +static void bcm2838_thermal_register_types(void)
> +{
> +    type_register_static(&bcm2838_thermal_info);
> +}
> +

thanks
-- PMM


  reply	other threads:[~2023-08-04 14:39 UTC|newest]

Thread overview: 216+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 13:24 [PATCH 00/44] Raspberry Pi 4B machine Sergey Kambalin
2023-07-26 13:24 ` [PATCH 01/44] Split out common part of BCM283X classes Sergey Kambalin
2023-08-03 15:48   ` Peter Maydell
2023-08-03 16:10     ` Peter Maydell
2023-08-03 16:15   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 02/44] Split out common part of peripherals Sergey Kambalin
2023-08-03 15:52   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 03/44] Split out raspi machine common part Sergey Kambalin
2023-08-04 10:33   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 04/44] Introduce BCM2838 SoC Sergey Kambalin
2023-08-03 16:31   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 05/44] Add GIC-400 to " Sergey Kambalin
2023-08-04 10:50   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 06/44] Add BCM2838 GPIO stub Sergey Kambalin
2023-08-04 12:11   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 07/44] Implement BCM2838 GPIO functionality Sergey Kambalin
2023-08-04 12:21   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 08/44] Connect SD controller to BCM2838 GPIO Sergey Kambalin
2023-08-04 12:28   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 09/44] Add GPIO and SD to BCM2838 periph Sergey Kambalin
2023-08-04 12:29   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 10/44] Add BCM2838 checkpoint support Sergey Kambalin
2023-08-04 12:30   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 11/44] Introduce Raspberry PI 4 machine Sergey Kambalin
2023-08-04 12:39   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 12/44] Temporary disable unimplemented rpi4b devices Sergey Kambalin
2023-08-04 12:53   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 13/44] Add memory region for BCM2837 RPiVid ASB Sergey Kambalin
2023-08-04 12:56   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 14/44] Add BCM2838 PCIE Root Complex Sergey Kambalin
2023-08-04 13:04   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 15/44] Add BCM2838 PCIE host Sergey Kambalin
2023-08-04 13:09   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 16/44] Enable BCM2838 PCIE Sergey Kambalin
2023-08-04 13:09   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 17/44] Add RNG200 skeleton Sergey Kambalin
2023-08-04 13:25   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 18/44] Add RNG200 RNG and RBG Sergey Kambalin
2023-08-04 14:27   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 19/44] Add RNG200 timer Sergey Kambalin
2023-08-04 14:31   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 20/44] Implement BCM2838 thermal sensor Sergey Kambalin
2023-08-04 14:38   ` Peter Maydell [this message]
2023-07-26 13:24 ` [PATCH 21/44] Add clock_isp stub Sergey Kambalin
2023-08-04 14:39   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 22/44] Add GENET stub Sergey Kambalin
2023-08-04 14:47   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 23/44] Add GENET register structs. Part 1 Sergey Kambalin
2023-08-04 14:48   ` Peter Maydell
2023-07-26 13:24 ` [PATCH 24/44] Add GENET register structs. Part 2 Sergey Kambalin
2023-07-26 13:24 ` [PATCH 25/44] Add GENET register structs. Part 3 Sergey Kambalin
2023-07-26 13:24 ` [PATCH 26/44] Add GENET register structs. Part 4 Sergey Kambalin
2023-07-26 13:24 ` [PATCH 27/44] Add GENET register access macros Sergey Kambalin
2023-07-26 13:24 ` [PATCH 28/44] Impl GENET register ops Sergey Kambalin
2023-07-26 13:24 ` [PATCH 29/44] Impl GENET MDIO Sergey Kambalin
2023-07-26 13:24 ` [PATCH 30/44] Impl GENET TX path Sergey Kambalin
2023-07-26 13:24 ` [PATCH 31/44] Impl GENET RX path Sergey Kambalin
2023-07-26 13:25 ` [PATCH 32/44] Enable BCM2838 GENET controller Sergey Kambalin
2023-08-04 14:49   ` Peter Maydell
2023-07-26 13:25 ` [PATCH 33/44] Connect RNG200, PCIE and GENET to GIC Sergey Kambalin
2023-08-04 14:53   ` Peter Maydell
2023-07-26 13:25 ` [PATCH 34/44] Add Rpi4b boot tests Sergey Kambalin
2023-08-04 14:54   ` Peter Maydell
2023-07-26 13:25 ` [PATCH 35/44] Add mailbox test stub Sergey Kambalin
2023-08-04 14:55   ` Peter Maydell
2023-07-26 13:25 ` [PATCH 36/44] Add mailbox test constants Sergey Kambalin
2023-07-26 13:25 ` [PATCH 37/44] Add mailbox tests tags. Part 1 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 38/44] Add mailbox tests tags. Part 2 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 39/44] Add mailbox tests tags. Part 3 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 40/44] Add mailbox property tests. Part 1 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 41/44] Add mailbox property tests. Part 2 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 42/44] Add mailbox property tests. Part 3 Sergey Kambalin
2023-07-26 13:25 ` [PATCH 43/44] Add missed BCM2835 properties Sergey Kambalin
2023-08-04 15:08   ` Peter Maydell
2023-07-26 13:25 ` [PATCH 44/44] Append added properties to mailbox test Sergey Kambalin
2023-08-04 12:13 ` [PATCH 00/44] Raspberry Pi 4B machine Peter Maydell
2023-08-04 15:09   ` Peter Maydell
2023-10-09  7:06 ` Ben Dooks
2023-12-03 17:06 ` [PATCH v2 00/45] " Sergey Kambalin
2023-12-03 21:28 ` [PATCH " Sergey Kambalin
2023-12-03 21:28   ` [PATCH 01/45] Split out common part of BCM283X classes Sergey Kambalin
2023-12-03 21:28     ` [PATCH 02/45] Split out common part of peripherals Sergey Kambalin
2023-12-03 21:28       ` [PATCH 03/45] Split out raspi machine common part Sergey Kambalin
2023-12-03 21:28         ` [PATCH 04/45] Introduce BCM2838 SoC Sergey Kambalin
2023-12-03 21:28           ` [PATCH 05/45] Add GIC-400 to " Sergey Kambalin
2023-12-03 21:28             ` [PATCH 06/45] Add BCM2838 GPIO stub Sergey Kambalin
2023-12-03 21:28               ` [PATCH 07/45] Implement BCM2838 GPIO functionality Sergey Kambalin
2023-12-03 21:28                 ` [PATCH 08/45] Connect SD controller to BCM2838 GPIO Sergey Kambalin
2023-12-03 21:28                   ` [PATCH 09/45] Add GPIO and SD to BCM2838 periph Sergey Kambalin
2023-12-03 21:28                     ` [PATCH 10/45] Add BCM2838 checkpoint support Sergey Kambalin
2023-12-03 21:28                       ` [PATCH 11/45] Introduce Raspberry PI 4 machine Sergey Kambalin
2023-12-03 21:28                         ` [PATCH 12/45] Temporarily disable unimplemented rpi4b devices Sergey Kambalin
2023-12-03 21:28                           ` [PATCH 13/45] Add memory region for BCM2837 RPiVid ASB Sergey Kambalin
2023-12-03 21:28                             ` [PATCH 14/45] Add BCM2838 PCIE Root Complex Sergey Kambalin
2023-12-03 21:28                               ` [PATCH 15/45] Add BCM2838 PCIE host Sergey Kambalin
2023-12-03 21:28                                 ` [PATCH 16/45] Enable BCM2838 PCIE Sergey Kambalin
2023-12-03 21:28                                   ` [PATCH 17/45] Add RNG200 skeleton Sergey Kambalin
2023-12-03 21:28                                     ` [PATCH 18/45] Add RNG200 RNG and RBG Sergey Kambalin
2023-12-03 21:28                                       ` [PATCH 19/45] Get rid of RNG200 timer Sergey Kambalin
2023-12-03 21:28                                         ` [PATCH 20/45] Implement BCM2838 thermal sensor Sergey Kambalin
2023-12-03 21:28                                           ` [PATCH 21/45] Add clock_isp stub Sergey Kambalin
2023-12-03 21:28                                             ` [PATCH 22/45] Add GENET stub Sergey Kambalin
2023-12-03 21:28                                               ` [PATCH 23/45] Add GENET register structs. Part 1 Sergey Kambalin
2023-12-03 21:28                                                 ` [PATCH 24/45] Add GENET register structs. Part 2 Sergey Kambalin
2023-12-03 21:28                                                   ` [PATCH 25/45] Add GENET register structs. Part 3 Sergey Kambalin
2023-12-03 21:28                                                     ` [PATCH 26/45] Add GENET register structs. Part 4 Sergey Kambalin
2023-12-03 21:28                                                       ` [PATCH 27/45] Add GENET register access macros Sergey Kambalin
2023-12-03 21:28                                                         ` [PATCH 28/45] Implement GENET register ops Sergey Kambalin
2023-12-03 21:28                                                           ` [PATCH 29/45] Implement GENET MDIO Sergey Kambalin
2023-12-03 21:28                                                             ` [PATCH 30/45] Implement GENET TX path Sergey Kambalin
2023-12-03 21:28                                                               ` [PATCH 31/45] Implement GENET RX path Sergey Kambalin
2023-12-03 21:28                                                                 ` [PATCH 32/45] Enable BCM2838 GENET controller Sergey Kambalin
2023-12-03 21:28                                                                   ` [PATCH 33/45] Connect RNG200, PCIE and GENET to GIC Sergey Kambalin
2023-12-03 21:28                                                                     ` [PATCH 34/45] Add Rpi4b boot tests Sergey Kambalin
2023-12-03 21:28                                                                       ` [PATCH 35/45] Add mailbox test stub Sergey Kambalin
2023-12-03 21:28                                                                         ` [PATCH 36/45] Add mailbox test constants Sergey Kambalin
2023-12-03 21:28                                                                           ` [PATCH 37/45] Add mailbox tests tags. Part 1 Sergey Kambalin
2023-12-03 21:28                                                                             ` [PATCH 38/45] Add mailbox tests tags. Part 2 Sergey Kambalin
2023-12-03 21:28                                                                               ` [PATCH 39/45] Add mailbox tests tags. Part 3 Sergey Kambalin
2023-12-03 21:29                                                                                 ` [PATCH 40/45] Add mailbox property tests. Part 1 Sergey Kambalin
2023-12-03 21:29                                                                                   ` [PATCH 41/45] Add mailbox property tests. Part 2 Sergey Kambalin
2023-12-03 21:29                                                                                     ` [PATCH 42/45] Add mailbox property tests. Part 3 Sergey Kambalin
2023-12-03 21:29                                                                                       ` [PATCH 43/45] Add missed BCM2835 properties Sergey Kambalin
2023-12-03 21:29                                                                                         ` [PATCH 44/45] Append added properties to mailbox test Sergey Kambalin
2023-12-03 21:29                                                                                           ` [PATCH 45/45] Add RPi4B to paspi4.rst Sergey Kambalin
2023-12-03 21:48 ` [PATCH v3 00/45] Raspberry Pi 4B machine Sergey Kambalin
2023-12-03 21:48   ` [PATCH v3 01/45] Split out common part of BCM283X classes Sergey Kambalin
2023-12-03 21:48     ` [PATCH v3 02/45] Split out common part of peripherals Sergey Kambalin
2023-12-03 21:48       ` [PATCH v3 03/45] Split out raspi machine common part Sergey Kambalin
2023-12-03 21:48         ` [PATCH v3 04/45] Introduce BCM2838 SoC Sergey Kambalin
2023-12-03 21:48           ` [PATCH v3 05/45] Add GIC-400 to " Sergey Kambalin
2023-12-03 21:48             ` [PATCH v3 06/45] Add BCM2838 GPIO stub Sergey Kambalin
2023-12-03 21:48               ` [PATCH v3 07/45] Implement BCM2838 GPIO functionality Sergey Kambalin
2023-12-03 21:48                 ` [PATCH v3 08/45] Connect SD controller to BCM2838 GPIO Sergey Kambalin
2023-12-03 21:48                   ` [PATCH v3 09/45] Add GPIO and SD to BCM2838 periph Sergey Kambalin
2023-12-03 21:48                     ` [PATCH v3 10/45] Add BCM2838 checkpoint support Sergey Kambalin
2023-12-03 21:48                       ` [PATCH v3 11/45] Introduce Raspberry PI 4 machine Sergey Kambalin
2023-12-03 21:48                         ` [PATCH v3 12/45] Temporarily disable unimplemented rpi4b devices Sergey Kambalin
2023-12-03 21:48                           ` [PATCH v3 13/45] Add memory region for BCM2837 RPiVid ASB Sergey Kambalin
2023-12-03 21:48                             ` [PATCH v3 14/45] Add BCM2838 PCIE Root Complex Sergey Kambalin
2023-12-03 21:48                               ` [PATCH v3 15/45] Add BCM2838 PCIE host Sergey Kambalin
2023-12-03 21:48                                 ` [PATCH v3 16/45] Enable BCM2838 PCIE Sergey Kambalin
2023-12-03 21:48                                   ` [PATCH v3 17/45] Add RNG200 skeleton Sergey Kambalin
2023-12-03 21:48                                     ` [PATCH v3 18/45] Add RNG200 RNG and RBG Sergey Kambalin
2023-12-03 21:48                                       ` [PATCH v3 19/45] Get rid of RNG200 timer Sergey Kambalin
2023-12-03 21:48                                         ` [PATCH v3 20/45] Implement BCM2838 thermal sensor Sergey Kambalin
2023-12-03 21:48                                           ` [PATCH v3 21/45] Add clock_isp stub Sergey Kambalin
2023-12-03 21:48                                             ` [PATCH v3 22/45] Add GENET stub Sergey Kambalin
2023-12-03 21:48                                               ` [PATCH v3 23/45] Add GENET register structs. Part 1 Sergey Kambalin
2023-12-03 21:48                                                 ` [PATCH v3 24/45] Add GENET register structs. Part 2 Sergey Kambalin
2023-12-03 21:48                                                   ` [PATCH v3 25/45] Add GENET register structs. Part 3 Sergey Kambalin
2023-12-03 21:48                                                     ` [PATCH v3 26/45] Add GENET register structs. Part 4 Sergey Kambalin
2023-12-03 21:48                                                       ` [PATCH v3 27/45] Add GENET register access macros Sergey Kambalin
2023-12-03 21:48                                                         ` [PATCH v3 28/45] Implement GENET register ops Sergey Kambalin
2023-12-03 21:48                                                           ` [PATCH v3 29/45] Implement GENET MDIO Sergey Kambalin
2023-12-03 21:48                                                             ` [PATCH v3 30/45] Implement GENET TX path Sergey Kambalin
2023-12-03 21:48                                                               ` [PATCH v3 31/45] Implement GENET RX path Sergey Kambalin
2023-12-03 21:48                                                                 ` [PATCH v3 32/45] Enable BCM2838 GENET controller Sergey Kambalin
2023-12-03 21:48                                                                   ` [PATCH v3 33/45] Connect RNG200, PCIE and GENET to GIC Sergey Kambalin
2023-12-03 21:48                                                                     ` [PATCH v3 34/45] Add Rpi4b boot tests Sergey Kambalin
2023-12-03 21:49                                                                       ` [PATCH v3 35/45] Add mailbox test stub Sergey Kambalin
2023-12-03 21:49                                                                         ` [PATCH v3 36/45] Add mailbox test constants Sergey Kambalin
2023-12-03 21:49                                                                           ` [PATCH v3 37/45] Add mailbox tests tags. Part 1 Sergey Kambalin
2023-12-03 21:49                                                                             ` [PATCH v3 38/45] Add mailbox tests tags. Part 2 Sergey Kambalin
2023-12-03 21:49                                                                               ` [PATCH v3 39/45] Add mailbox tests tags. Part 3 Sergey Kambalin
2023-12-03 21:49                                                                                 ` [PATCH v3 40/45] Add mailbox property tests. Part 1 Sergey Kambalin
2023-12-03 21:49                                                                                   ` [PATCH v3 41/45] Add mailbox property tests. Part 2 Sergey Kambalin
2023-12-03 21:49                                                                                     ` [PATCH v3 42/45] Add mailbox property tests. Part 3 Sergey Kambalin
2023-12-03 21:49                                                                                       ` [PATCH v3 43/45] Add missed BCM2835 properties Sergey Kambalin
2023-12-03 21:49                                                                                         ` [PATCH v3 44/45] Append added properties to mailbox test Sergey Kambalin
2023-12-03 21:49                                                                                           ` [PATCH v3 45/45] Add RPi4B to paspi4.rst Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 00/45] Raspberry Pi 4B machine Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 01/45] Split out common part of BCM283X classes Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 02/45] Split out common part of peripherals Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 03/45] Split out raspi machine common part Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 04/45] Introduce BCM2838 SoC Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 05/45] Add GIC-400 to " Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 06/45] Add BCM2838 GPIO stub Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 07/45] Implement BCM2838 GPIO functionality Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 08/45] Connect SD controller to BCM2838 GPIO Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 09/45] Add GPIO and SD to BCM2838 periph Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 10/45] Add BCM2838 checkpoint support Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 11/45] Introduce Raspberry PI 4 machine Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 12/45] Temporarily disable unimplemented rpi4b devices Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 13/45] Add memory region for BCM2837 RPiVid ASB Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 14/45] Add BCM2838 PCIE Root Complex Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 15/45] Add BCM2838 PCIE host Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 16/45] Enable BCM2838 PCIE Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 17/45] Add RNG200 skeleton Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 18/45] Add RNG200 RNG and RBG Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 19/45] Get rid of RNG200 timer Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 20/45] Implement BCM2838 thermal sensor Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 21/45] Add clock_isp stub Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 22/45] Add GENET stub Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 23/45] Add GENET register structs. Part 1 Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 24/45] Add GENET register structs. Part 2 Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 25/45] Add GENET register structs. Part 3 Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 26/45] Add GENET register structs. Part 4 Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 27/45] Add GENET register access macros Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 28/45] Implement GENET register ops Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 29/45] Implement GENET MDIO Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 30/45] Implement GENET TX path Sergey Kambalin
2023-12-03 23:41 ` [PATCH v3 31/45] Implement GENET RX path Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 32/45] Enable BCM2838 GENET controller Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 33/45] Connect RNG200, PCIE and GENET to GIC Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 34/45] Add Rpi4b boot tests Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 35/45] Add mailbox test stub Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 36/45] Add mailbox test constants Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 37/45] Add mailbox tests tags. Part 1 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 38/45] Add mailbox tests tags. Part 2 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 39/45] Add mailbox tests tags. Part 3 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 40/45] Add mailbox property tests. Part 1 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 41/45] Add mailbox property tests. Part 2 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 42/45] Add mailbox property tests. Part 3 Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 43/45] Add missed BCM2835 properties Sergey Kambalin
2023-12-03 23:42 ` [PATCH v3 44/45] Append added properties to mailbox test Sergey Kambalin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_AkwcWaDWeewzB7OVzmKH-Cc5n7G8oipnYRayqKd3ndA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=serg.oker@gmail.com \
    --cc=sergey.kambalin@auriga.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).