From: Peter Maydell <peter.maydell@linaro.org>
To: Manolo de Medici <manolodemedici@gmail.com>
Cc: qemu-devel@nongnu.org, bug-hurd@gnu.org,
Eric Blake <eblake@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH v2 1/4] Include new arbitrary limits if not already defined
Date: Mon, 22 Jan 2024 17:19:19 +0000 [thread overview]
Message-ID: <CAFEAcA_BAz3SyqHLkU6YKedHvZTVUNsjy2tkxWJTBd9JZNgtnA@mail.gmail.com> (raw)
In-Reply-To: <CAHP40mmk4cPk6ZHETfq5BtQxK63A6PiuCKrvv4yyOPBxVTW+OQ@mail.gmail.com>
On Thu, 18 Jan 2024 at 16:03, Manolo de Medici <manolodemedici@gmail.com> wrote:
>
> qemu uses the PATH_MAX and IOV_MAX constants extensively
> in the code. Define these constants to sensible values ourselves
> if the system doesn't define them already.
>
> Signed-off-by: Manolo de Medici <manolo.demedici@gmail.com>
> ---
> include/qemu/osdep.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 9a405bed89..9fb6ac5c64 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -363,6 +363,14 @@ void QEMU_ERROR("code path is reachable")
> #define TIME_MAX TYPE_MAXIMUM(time_t)
> #endif
>
> +#ifndef PATH_MAX
> +#define PATH_MAX 1024
> +#endif
> +
> +#ifndef IOV_MAX
> +#define IOV_MAX 1024
> +#endif
> +
> /* Mac OSX has a <stdint.h> bug that incorrectly defines SIZE_MAX with
> * the wrong type. Our replacement isn't usable in preprocessor
> * expressions, but it is sufficient for our needs. */
Ccing some people who know more about portability concerns
than I do...
thanks
-- PMM
next prev parent reply other threads:[~2024-01-22 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 16:02 [PATCH v2 1/4] Include new arbitrary limits if not already defined Manolo de Medici
2024-01-22 17:19 ` Peter Maydell [this message]
2024-01-24 17:42 ` Eric Blake
2024-01-22 17:26 ` Daniel P. Berrangé
2024-01-22 17:40 ` Peter Maydell
2024-01-23 15:16 ` Manolo de Medici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_BAz3SyqHLkU6YKedHvZTVUNsjy2tkxWJTBd9JZNgtnA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=bug-hurd@gnu.org \
--cc=eblake@redhat.com \
--cc=manolodemedici@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).