qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Marcel Apfelbaum <marcel.a@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Li Liu <john.liuli@huawei.com>, Michael Tokarev <mjt@tls.msk.ru>,
	QEMU Developers <qemu-devel@nongnu.org>,
	peter.huangpeng@huawei.com, Luonengjun <luonengjun@huawei.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v7] tests/bios-tables-test: check the value returned by fopen()
Date: Mon, 18 Aug 2014 22:01:22 +0100	[thread overview]
Message-ID: <CAFEAcA_BFhsEp3STyD7HM06WuzLKxLWXj2mtmL-9iGjWZ6HLpg@mail.gmail.com> (raw)
In-Reply-To: <20140818193641.GB29446@redhat.com>

On 18 August 2014 20:36, Michael S. Tsirkin <mst@redhat.com> wrote:
> Does test fail if this path is triggered?

If our test harness doesn't report failure when a test
binary returns with a non-zero exit code then the
harness is broken, because there are other test
binaries that rely on that.

thanks
-- PMM

      reply	other threads:[~2014-08-18 21:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  7:54 [Qemu-devel] [PATCH v7] tests/bios-tables-test: check the value returned by fopen() zhanghailiang
2014-08-18  8:10 ` Peter Maydell
2014-08-18  9:13 ` Marcel Apfelbaum
2014-08-18 11:37   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-18 12:26     ` Marcel Apfelbaum
2014-08-18 13:51     ` Michael S. Tsirkin
2014-08-18 11:38 ` Michael Tokarev
2014-08-18 13:44   ` Michael S. Tsirkin
2014-08-18 14:24     ` Michael Tokarev
2014-08-18 19:36       ` Michael S. Tsirkin
2014-08-18 21:01         ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_BFhsEp3STyD7HM06WuzLKxLWXj2mtmL-9iGjWZ6HLpg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=john.liuli@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=marcel.a@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).