From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJU3q-00039t-8L for qemu-devel@nongnu.org; Mon, 18 Aug 2014 17:01:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJU3j-0004kv-JR for qemu-devel@nongnu.org; Mon, 18 Aug 2014 17:01:50 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:48990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJU3j-0004ko-Ce for qemu-devel@nongnu.org; Mon, 18 Aug 2014 17:01:43 -0400 Received: by mail-la0-f42.google.com with SMTP id pv20so5147282lab.15 for ; Mon, 18 Aug 2014 14:01:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140818193641.GB29446@redhat.com> References: <1408348473-10104-1-git-send-email-zhang.zhanghailiang@huawei.com> <53F1E5A4.9060000@msgid.tls.msk.ru> <20140818134421.GA28795@redhat.com> <53F20C82.7050506@msgid.tls.msk.ru> <20140818193641.GB29446@redhat.com> From: Peter Maydell Date: Mon, 18 Aug 2014 22:01:22 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v7] tests/bios-tables-test: check the value returned by fopen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: zhanghailiang , Marcel Apfelbaum , QEMU Trivial , Li Liu , Michael Tokarev , QEMU Developers , peter.huangpeng@huawei.com, Luonengjun On 18 August 2014 20:36, Michael S. Tsirkin wrote: > Does test fail if this path is triggered? If our test harness doesn't report failure when a test binary returns with a non-zero exit code then the harness is broken, because there are other test binaries that rely on that. thanks -- PMM