Re: [Qemu-devel] [PULL v2 0/1] error: More error_setg() usage

[Peter Maydell <peter.maydell@linaro.org>]

On 12 November 2015 at 10:28, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 11 November 2015 at 17:59, Markus Armbruster <armbru@redhat.com> wrote:
>> v2: Indentation touched up
>>
>> The following changes since commit 3c07587d49458341510360557c849e93e9afaf59:
>>
>>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-20151111' into staging (2015-11-11 09:34:18 +0000)
>>
>> are available in the git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-11-11
>>
>> for you to fetch changes up to 455b0fde8c38a0794743e2e7c1a40018b7bee9f6:
>>
>>   error: More error_setg() usage (2015-11-11 18:56:26 +0100)
>>
>> ----------------------------------------------------------------
>> error: More error_setg() usage
>>
>> ----------------------------------------------------------------
>> Eric Blake (1):
>>       error: More error_setg() usage
>>
>>  block.c                       |  3 +--
>>  docs/writing-qmp-commands.txt | 20 +++++++++-----------
>>  hw/i386/pc.c                  |  6 +++---
>>  hw/net/rocker/rocker.c        |  6 ++----
>>  hw/net/rocker/rocker_of_dpa.c | 12 ++++--------
>>  qom/object.c                  |  4 ++--
>>  6 files changed, 21 insertions(+), 30 deletions(-)
>>
>> Eric Blake (1):
>>   error: More error_setg() usage
>
>
> Not clear whether this is the fault of these patches, but I get
> 'make check' failures on OSX:

...almost certainly not these patches. For some reason these
don't actually cause 'make check' to return non-zero, and
my "grep logs for warning/error etc" workflow wouldn't catch
them. I just happened to look at this log by hand.

thanks
-- PMM