qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Subbaraya Sundeep <sundeep.lkml@gmail.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Alistair Francis" <alistair23@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit
Date: Thu, 14 Sep 2017 18:14:54 +0100	[thread overview]
Message-ID: <CAFEAcA_D=4M2vyo4m2xPi_hFDCmoKHk5kLY3s1ota602ywgHTQ@mail.gmail.com> (raw)
In-Reply-To: <1504812251-23438-6-git-send-email-sundeep.lkml@gmail.com>

On 7 September 2017 at 20:24, Subbaraya Sundeep <sundeep.lkml@gmail.com> wrote:
> Emulated Emcraft's Smartfusion2 System On Module starter
> kit.
> +static void emcraft_sf2_machine_init(MachineClass *mc)
> +{
> +    mc->desc = "SmartFusion2 SOM kit from Emcraft (M2S010)";
> +    mc->init = emcraft_sf2_s2s010_init;
> +    mc->ignore_memory_transaction_failures = true;

Please don't set ignore_memory_transaction_failures in new boards.
This is a legacy-old-code-only flag.

New boards should define enough devices, either properly
or using create_unimplemented_device(), to make whatever code
they're being tested against run.

This is a firm requirement for this code to go into master,
because once we let a board in with the flag set it's almost
impossible to clear it because we don't know what guest
code that previously worked on the board will now break.

thanks
-- PMM

  reply	other threads:[~2017-09-14 17:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 19:24 [Qemu-devel] [Qemu devel v8 PATCH 0/5] Add support for Smartfusion2 SoC Subbaraya Sundeep
2017-09-07 19:24 ` [Qemu-devel] [Qemu devel v8 PATCH 1/5] msf2: Add Smartfusion2 System timer Subbaraya Sundeep
2017-09-07 19:24 ` [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block Subbaraya Sundeep
2017-09-14  4:36   ` Philippe Mathieu-Daudé
2017-09-14 13:13     ` Peter Maydell
2017-09-14 15:30       ` sundeep subbaraya
2017-09-14 18:05         ` Philippe Mathieu-Daudé
2017-09-14 15:34     ` sundeep subbaraya
2017-09-17 23:57     ` Philippe Mathieu-Daudé
2017-09-18  6:29       ` sundeep subbaraya
2017-09-07 19:24 ` [Qemu-devel] [Qemu devel v8 PATCH 3/5] msf2: Add Smartfusion2 SPI controller Subbaraya Sundeep
2017-09-12 23:50   ` Alistair Francis
2017-09-13  2:21     ` sundeep subbaraya
2017-09-07 19:24 ` [Qemu-devel] [Qemu devel v8 PATCH 4/5] msf2: Add Smartfusion2 SoC Subbaraya Sundeep
2017-09-07 21:38   ` Philippe Mathieu-Daudé
2017-09-08  7:26     ` sundeep subbaraya
2017-09-13  9:21       ` sundeep subbaraya
2017-09-13 17:07         ` sundeep subbaraya
2017-09-13 17:24         ` Philippe Mathieu-Daudé
2017-09-07 19:24 ` [Qemu-devel] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit Subbaraya Sundeep
2017-09-14 17:14   ` Peter Maydell [this message]
2017-09-14 17:45     ` Philippe Mathieu-Daudé
2017-09-15  6:31     ` sundeep subbaraya
2017-09-07 21:44 ` [Qemu-devel] [Qemu devel v8 PATCH 0/5] Add support for Smartfusion2 SoC Philippe Mathieu-Daudé
2017-09-08  7:24   ` sundeep subbaraya
2017-09-14  4:10     ` Philippe Mathieu-Daudé
2017-09-14 17:06       ` Alistair Francis
2017-09-14 17:17         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_D=4M2vyo4m2xPi_hFDCmoKHk5kLY3s1ota602ywgHTQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alistair23@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sundeep.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).