From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C297C04AB6 for ; Tue, 28 May 2019 18:35:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 559BB208CB for ; Tue, 28 May 2019 18:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u44uJ5m+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 559BB208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:40879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVgwY-0003il-G6 for qemu-devel@archiver.kernel.org; Tue, 28 May 2019 14:35:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVguX-0002KB-U6 for qemu-devel@nongnu.org; Tue, 28 May 2019 14:33:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVguS-0007KN-B6 for qemu-devel@nongnu.org; Tue, 28 May 2019 14:33:18 -0400 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:32838) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVguO-0007B6-Nb for qemu-devel@nongnu.org; Tue, 28 May 2019 14:33:14 -0400 Received: by mail-oi1-x22d.google.com with SMTP id q186so15102174oia.0 for ; Tue, 28 May 2019 11:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hflmveIUT9776d/4hJf9/0kiwLAc22FOLJGzIuxs74I=; b=u44uJ5m+xsmEkQAtFUp2+zT7BDF7ym0b9660XLb3qaP2812VvZUUG02y8QXxqpIUx/ 7AZpy2/faEWmXaEiFXA6K2q8kCE3vLZ7VQV/0DiadFOMEvevN9p0Qi3lyMLFB8pN1wv/ Sbnnvw7+IiS8hpyr3VurmzH+r127/0azHwoz0fwLEAHY9qSc1hdblHbtI5KndAQcC1no bwpfmfkA5kDRYc6k49Fnol0v6RNrtIKXCrMJFf6RLg7TsCs1hasuCkyXqcygprNV63H0 EdyKWMYF4yo4s48ACIyprzykFVBcVUac/i2LmfsSQByeJ2Masf3fA/MhLKlymLrgOcSu 8NtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hflmveIUT9776d/4hJf9/0kiwLAc22FOLJGzIuxs74I=; b=LxE0XMaC2fWJluxt83JPJjMlh9xRNL8pIV3pexW98rUoMqQcpb5C4qpvMUEhufAo10 gjQIQXHXsvO5QeLvbEIu3qbNpjyj/Vp5u24HATmQFWbOfviHpcmCFDSM2Ovk4Rl8mG5p s36bcILfANAkRs2lqYBuvCwe5YE48s3b02oKUHBid9GLg1ITuRJmM2PGT5oMR6vr0yFH aO5lyxCXs455GdK+9OHeTzQzFmbb7x84CwZ6AA4X+z0HmrxyPF9QJ/4D+Xw0nCiPvR6o q5/n8nAsOVV014mPseTUTlXXsgfKlhjnDjrhykVWb0Zh0ULYRBhxv+oFnQaflLFea5Kf N9bw== X-Gm-Message-State: APjAAAWuw7+eVuBrr4AfMVJJsIfvjoxY3EB83rzPFjNNVARiwmorhyM6 79YPqwrL+kkrQvETMkJTRhu53H0CZ6VHT+A9rQdhNw== X-Google-Smtp-Source: APXvYqy5k/2a92r+bhbTL4lJxiqLsbW6v6K0zcj55PYGm/0OVqi3U1BFW0JTnlC4pruDf39SwtUlbd1y60h/O2HIf7c= X-Received: by 2002:aca:cd12:: with SMTP id d18mr3399573oig.146.1559068382420; Tue, 28 May 2019 11:33:02 -0700 (PDT) MIME-Version: 1.0 References: <87lfyqla7r.fsf@dusky.pond.sub.org> In-Reply-To: <87lfyqla7r.fsf@dusky.pond.sub.org> From: Peter Maydell Date: Tue, 28 May 2019 19:32:51 +0100 Message-ID: To: Markus Armbruster Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22d Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wulff , Sagar Karandikar , David Hildenbrand , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Max Filippov , Dmitry Fleytman , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , "Michael S. Tsirkin" , Laszlo Ersek , Halil Pasic , Christian Borntraeger , Anthony Perard , Richard Henderson , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Riku Voipio , Eduardo Habkost , Alistair Francis , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Paul Durrant , Stafford Horne , =?UTF-8?B?QWxleCBCZW5uw6ll?= , David Gibson , "Daniel P. Berrange" , Claudio Fontana , Bastian Koppelmann , Cornelia Huck , Claudio Fontana , Laurent Vivier , Andrew Baumann , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Michael Walle , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 May 2019 at 19:12, Markus Armbruster wrote: > I append the alphabetical list of headers without multiple inclusion > guards (as reported by scripts/clean-header-guards -nv), followed by the > same list sorted into maintainer buckets. If you're cc'ed, please find > your bucket(s), and tell me which headers intentionally lack guards. > FPU emulation > M: Aurelien Jarno > M: Peter Maydell > M: Alex Benn=C3=A9e > fpu/softfloat-specialize.h > include/fpu/softfloat-macros.h I think that include/fpu/softfloat-macros.h should ideally have header guards. fpu/softfloat-specialize.h is a bit odd as it's intended to be included exactly once, by fpu/softfloat.c. Guards wouldn't hurt, I think, but it might be cleanest to rename it to fpu/softfloat-specialize.inc.c to match our convention for "lump of C which is textually included but isn't a header". > ARM > M: Peter Maydell > target/arm/helper-a64.h > target/arm/helper-sve.h > target/arm/helper.h > target/arm/op_addsub.h All intentional -- target/*/helper.h and anything it includes is intended to be included multiple times for different purposes (the includer #defines various macros appropriately to produce different effects). > Allwinner-a10 > M: Beniamino Galvani > M: Peter Maydell > include/hw/arm/allwinner-a10.h This appears to me to have an include guard: perhaps your check doesn't recognize the variant where the #define appears just before the #endif rather than just after the #ifndef ? > ARM PrimeCell and CMSDK devices > M: Peter Maydell > hw/display/pl110_template.h Intentional, like all the hw/display/*_template.h headers: they're included multiple times with various definitions of BITS to generate different functions. (Note that there's an item on the BiteSizedTasks page which suggests that we could clean up all of these because only the 32-bit case is used now that our display surfaces are always 32-bits-per-pixel.) > Raspberry Pi > M: Peter Maydell > R: Andrew Baumann > R: Philippe Mathieu-Daud=C3=A9 > include/hw/arm/raspi_platform.h Mistake, should have a guard. > PXA2XX > M: Andrzej Zaborowski > M: Peter Maydell > hw/display/pxa2xx_template.h Intentional, see above. > Xilinx ZynqMP > M: Alistair Francis > M: Edgar E. Iglesias > M: Peter Maydell > include/hw/arm/xlnx-zynqmp.h > include/hw/display/xlnx_dp.h > include/hw/dma/xlnx-zynq-devcfg.h These all have guards in non-standard formats. > include/hw/timer/xlnx-zynqmp-rtc.h Mistake, should have a guard. > OMAP > M: Peter Maydell > hw/display/omap_lcd_template.h Intentional, see above. > include/hw/arm/omap.h Has a guard in a non-standard form. > UNMAINTAINED > ------------ > hw/display/tc6393xb_template.h Intentional (see above) > include/hw/char/cadence_uart.h Another with a guard which isn't of a style your check detects. thanks -- PMM