From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv579-0000qh-En for qemu-devel@nongnu.org; Mon, 23 Dec 2013 08:00:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vv573-0004RE-HF for qemu-devel@nongnu.org; Mon, 23 Dec 2013 08:00:07 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:65326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv573-0004Qo-CI for qemu-devel@nongnu.org; Mon, 23 Dec 2013 08:00:01 -0500 Received: by mail-pa0-f44.google.com with SMTP id fa1so5313158pad.3 for ; Mon, 23 Dec 2013 05:00:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <52B831AC.8030207@redhat.com> References: <20131223115622.GA6490@redhat.com> <52B831AC.8030207@redhat.com> From: Peter Maydell Date: Mon, 23 Dec 2013 12:59:39 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: John Rigby , "Michael S. Tsirkin" , Alexander Graf , QEMU Developers , Laszlo Ersek , Richard Henderson On 23 December 2013 12:50, Paolo Bonzini wrote: > Il 23/12/2013 13:37, Peter Maydell ha scritto: >> At a minimum, if we take this approach we should add TODO comments >> to the effect that the NULL terminator and the if() can be removed >> when the first real AArch64 CPU is added. >> >> I think I'd rather put the if (!info->name) continue into the function >> which is doing the looping over the array. > > Or just change the termination condition from a check on the array size > to one on info->name. That would take it out of line with the equivalent 32 bit ARM code (and also moxie and openrisc for what little that's worth) and be fractionally more tedious to revert later. thanks -- PMM