From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790A9C433E0 for ; Fri, 15 Jan 2021 11:51:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D66923730 for ; Fri, 15 Jan 2021 11:51:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D66923730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Ne1-0008OJ-4t for qemu-devel@archiver.kernel.org; Fri, 15 Jan 2021 06:51:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Nd8-0007h0-LS for qemu-devel@nongnu.org; Fri, 15 Jan 2021 06:51:04 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:38085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Nd4-00057K-T1 for qemu-devel@nongnu.org; Fri, 15 Jan 2021 06:51:02 -0500 Received: by mail-ed1-x529.google.com with SMTP id s11so1898363edd.5 for ; Fri, 15 Jan 2021 03:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WZaFu23Ow4jstvd34MiVFcsKpmwUSb32zVx2M8YTfTA=; b=MAy2PaxrbK4ILBTrNNiSXbrfayei5wB3zVe9i6lNvTZrb9DFJ7DR23Mv9eTfEHtGrA p6k4ywQDcAoOKzZwNT/tOhnzhGOt/MKW+64a8HKwJ3on7B3i170ciP6Vic8oSteYn0H7 DosaJaKjfZB7Vs8KrZONqL16afS78Q2rw99pHLd2L2qnK0vPbFtJEimiK1IXruP9XPrg gj77VrY+d7HYfWxYWiK1wyu+7cy59tFea4CyTY6j9TrrWxG4XdsZu9vSKYCUbjNUG0ij KQH8ISGsWIlbpCv0d/M0z/gkUzlYx7CjKQ/Uxcgo7hGOPVtC6xVpoYCzgzssAGIeDP83 zMyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WZaFu23Ow4jstvd34MiVFcsKpmwUSb32zVx2M8YTfTA=; b=fqjre5OCLal/0d8ZkuqY38PMRs3dBem2EupYZytUGAP0StFQyIaN7Drl8PPx7plkxT S4iDSXEUujmTzLUM1xOrC08G5WFiHCM7VJb1IbNKo6FqckrThUaXLwTm2gtjptT8IGvD WEoxYITQ0/26FJZ65Go5ul8Ne/zYHT+jF5WS3+WdqPcsBgVnMjizFnowsumG3OUbVsdo sLUdLJsyEvw7VtNT/83h0K9THSLXgWnvU0m4wPqoOj72UOVraOMVMwd/APus9M+mAf4i Pyk4LDhAOdE3zB5U3Pyh7d8To5wb+ky2jFBe/eKtRvgKo8ox3QtCRegYFkjmQ4kPEEq2 SLWQ== X-Gm-Message-State: AOAM531KeLq2CWOWIr3hxunwCpMATVe2ER7CeguXxy99Dj5wF7wnpDNm SGFlXglIczh2vbTCpbBnGnAJcBtTc2igpwxqNu7WBA== X-Google-Smtp-Source: ABdhPJx2I5MX8FTZtzsPDK+EzcOQ81CP8qsf2CpFyvooiZHA5Q6dTRcaML8sHkzbcGw8BKQQc19RMMRC+G51WlisjF0= X-Received: by 2002:a05:6402:366:: with SMTP id s6mr9061142edw.44.1610711456864; Fri, 15 Jan 2021 03:50:56 -0800 (PST) MIME-Version: 1.0 References: <20201104092900.21214-1-green.wan@sifive.com> In-Reply-To: <20201104092900.21214-1-green.wan@sifive.com> From: Peter Maydell Date: Fri, 15 Jan 2021 11:50:45 +0000 Message-ID: Subject: Re: [PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite To: Green Wan Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , Bin Meng , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ping! This patch was trying to fix a Coverity issue (CID 1435959, 1435960, 1435961) -- is anybody planning to review it? (I'm not entirely sure 'guest error' is the right warning category, but I don't know the specifics of this device.) thanks -- PMM On Wed, 4 Nov 2020 at 09:29, Green Wan wrote: > > Fix code coverage issues by checking return value and handling fail case > of blk_pread() and blk_pwrite(). Return default value 0xff if read fails. > > Signed-off-by: Green Wan > --- > hw/misc/sifive_u_otp.c | 31 +++++++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/hw/misc/sifive_u_otp.c b/hw/misc/sifive_u_otp.c > index 60066375ab..4314727d0d 100644 > --- a/hw/misc/sifive_u_otp.c > +++ b/hw/misc/sifive_u_otp.c > @@ -62,8 +62,13 @@ static uint64_t sifive_u_otp_read(void *opaque, hwaddr addr, unsigned int size) > if (s->blk) { > int32_t buf; > > - blk_pread(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD, &buf, > - SIFIVE_U_OTP_FUSE_WORD); > + if (blk_pread(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD, &buf, > + SIFIVE_U_OTP_FUSE_WORD) < 0) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "read error index<%d>\n", s->pa); > + return 0xff; > + } > + > return buf; > } > > @@ -160,8 +165,12 @@ static void sifive_u_otp_write(void *opaque, hwaddr addr, > > /* write to backend */ > if (s->blk) { > - blk_pwrite(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD, > - &s->fuse[s->pa], SIFIVE_U_OTP_FUSE_WORD, 0); > + if (blk_pwrite(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD, > + &s->fuse[s->pa], SIFIVE_U_OTP_FUSE_WORD, > + 0) < 0) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "write error index<%d>\n", s->pa); > + } > } > > /* update written bit */ > @@ -248,12 +257,18 @@ static void sifive_u_otp_reset(DeviceState *dev) > int index = SIFIVE_U_OTP_SERIAL_ADDR; > > serial_data = s->serial; > - blk_pwrite(s->blk, index * SIFIVE_U_OTP_FUSE_WORD, > - &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0); > + if (blk_pwrite(s->blk, index * SIFIVE_U_OTP_FUSE_WORD, > + &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0) < 0) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "write error index<%d>\n", index); > + } > > serial_data = ~(s->serial); > - blk_pwrite(s->blk, (index + 1) * SIFIVE_U_OTP_FUSE_WORD, > - &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0); > + if (blk_pwrite(s->blk, (index + 1) * SIFIVE_U_OTP_FUSE_WORD, > + &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0) < 0) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "write error index<%d>\n", index + 1); > + } > } > > /* Initialize write-once map */ > -- > 2.17.1