From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C876EC4338F for ; Mon, 2 Aug 2021 12:10:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68B4C60FC2 for ; Mon, 2 Aug 2021 12:10:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68B4C60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAWmI-0007iZ-FN for qemu-devel@archiver.kernel.org; Mon, 02 Aug 2021 08:10:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAWd3-0006iz-H1 for qemu-devel@nongnu.org; Mon, 02 Aug 2021 08:01:09 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:38497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAWcy-0004R1-1I for qemu-devel@nongnu.org; Mon, 02 Aug 2021 08:01:09 -0400 Received: by mail-ed1-x52f.google.com with SMTP id y7so21866315eda.5 for ; Mon, 02 Aug 2021 05:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vHq8CWy0CabcoM7CFgey8Lk7fxauhOp6vwrj4z33uYc=; b=craAnEFVLGh2m+D+bQKGfKtWyZOUShfp0V0qyEKQxq8fo2kSuamDcReamZiDxFrKQg bmFQpk5x3wf1Y+/d4Znv2AgP6gROFn4nQW9PWwjE2rqbE5ljve9Z82UswbdmCa3TcSgz 0jk1WCnL6tOBzE6EiQVPtf4A2ozQRbnUTQAsdY3X49cWcsU+ywPQdGGSTg+0rGgATSKM tLmltgYVJUeYZLlpjwkCmRlhi83C89mX8UYxgB5Dk01pUkW+ZWGQVSW8an98HaHszoxS CvkxkdcNq5oER2yOCPPyHiLvVi8r/p2NO9cSKXSXZQBEF0NexX28jsUcnmQteMX6cTMa 23rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vHq8CWy0CabcoM7CFgey8Lk7fxauhOp6vwrj4z33uYc=; b=Z/V90c1TLil5bnKmYOGhLjw0CSRDGwncm6eH8vwzSosGl9EIj8gxRhaaWMZMMZYQyz f+Q25R1b698PgCSwBpRm7wkdGP5r0dhwP1Zfd7hH2hPGPAr0IbdsbjAF6uMuA8G/rY3h dF7s7ukmwwzLTL+3/mpi8sI/2vYVFatVdYyh9pbNEABGAwiEfzrWgMv9GCmOEQ3s8hrb nZL48mOgFWO/Ej41EpMWfrK9v9dNZmA/KZTK84G+mubMD+FKODyckTd8lPAfS6saHV6d LeRLVsJpyS3fIBxRsYOvlxzFiic73+zK4zwv2rIyUklXyUbmlbhifR11qDN7GZendxX8 9meA== X-Gm-Message-State: AOAM5300CKpqlARB93oL0d/uux6cs4f3JBRsG1rynMArdeAaoahyxpBn kEJsga+d3Y8j6HCyRtAw7YczTL9KK+v66Hwllq/xhQ== X-Google-Smtp-Source: ABdhPJy3f1Sey8ZDSHk4+rIqDFhZ32aKe3PwwY5OQkfrmC59xoaphAMeBmhfAv7dPzTm0UFnRe7sqqB5Co5cSylSjwk= X-Received: by 2002:a50:f615:: with SMTP id c21mr19360591edn.146.1627905662580; Mon, 02 Aug 2021 05:01:02 -0700 (PDT) MIME-Version: 1.0 References: <20210728181728.2012952-1-f4bug@amsat.org> <20210728181728.2012952-2-f4bug@amsat.org> In-Reply-To: <20210728181728.2012952-2-f4bug@amsat.org> From: Peter Maydell Date: Mon, 2 Aug 2021 13:00:19 +0100 Message-ID: Subject: Re: [PATCH-for-6.1 1/3] hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Bulekov , Qemu-block , Bin Meng , QEMU Developers , qemu-arm Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 28 Jul 2021 at 19:18, Philippe Mathieu-Daud=C3=A9 = wrote: > > Per the 'Physical Layer Simplified Specification Version 3.01', > Table 4-22: 'Block Oriented Write Protection Commands' > > SEND_WRITE_PROT (CMD30) > > If the card provides write protection features, this command asks > the card to send the status of the write protection bits [1]. > > [1] 32 write protection bits (representing 32 write protect groups > starting at the specified address) [...] > The last (least significant) bit of the protection bits corresponds > to the first addressed group. If the addresses of the last groups > are outside the valid range, then the corresponding write protection > bits shall be set to 0. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/sd/sd.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 1f964e022b1..707dcc12a14 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -822,7 +822,14 @@ static uint32_t sd_wpbits(SDState *sd, uint64_t addr= ) > > for (i =3D 0; i < 32; i++, wpnum++, addr +=3D WPGROUP_SIZE) { > assert(wpnum < sd->wpgrps_size); > - if (addr < sd->size && test_bit(wpnum, sd->wp_groups)) { > + if (addr >=3D sd->size) { > + /* > + * If the addresses of the last groups are outside the valid= range, > + * then the corresponding write protection bits shall be set= to 0. > + */ > + continue; > + } > + if (test_bit(wpnum, sd->wp_groups)) { Am I misreading it, or does this commit not actually change the behaviour of the code ? > ret |=3D (1 << i); > } > } > -- > 2.31.1 -- PMM