qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Chubb <peter.chubb@nicta.com.au>
Cc: Japheth.Lim@nicta.com.au, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.
Date: Mon, 15 Apr 2013 08:23:21 +0100	[thread overview]
Message-ID: <CAFEAcA_FTtC6Xu3myd2kgv-v=cTwKFmtF=7sYEm1B+QZEJ7XQQ@mail.gmail.com> (raw)
In-Reply-To: <84sj2s75yv.wl%peter@chubb.wattle.id.au>

On 15 April 2013 05:50, Peter Chubb <peter.chubb@nicta.com.au> wrote:
>
>
> Since patch
>    81465888c5306cd94abb9847e560796fd13d3c2f
>    target-arm: factor out handling of SRS instruction
> the SRS instruction has not worked in QEMU.
>
> The problem is a return directive that was removed in the
> refactoring, so after decoding the instruction, qemu would fall
> through to do stuff that it should not have done.

Nice catch for the ARM decoder, but not needed for thumb2
I think?

thanks
-- PMM

  reply	other threads:[~2013-04-15  7:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15  4:50 [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements Peter Chubb
2013-04-15  7:23 ` Peter Maydell [this message]
2013-04-15  7:29   ` Peter Chubb
2013-04-15  7:32     ` Peter Maydell
2013-04-15  9:53       ` [Qemu-devel] [PATCH v2] target-arm: Reinsert SRS missing return statement Peter Chubb
2013-04-15 10:08         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_FTtC6Xu3myd2kgv-v=cTwKFmtF=7sYEm1B+QZEJ7XQQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=Japheth.Lim@nicta.com.au \
    --cc=peter.chubb@nicta.com.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).