From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50032)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1URdlP-0003Ko-MP
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:23:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1URdlO-0001Bn-6S
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:23:43 -0400
Received: from mail-wg0-f47.google.com ([74.125.82.47]:56350)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1URdlN-0001Be-WD
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:23:42 -0400
Received: by mail-wg0-f47.google.com with SMTP id j13so1824736wgh.2
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 00:23:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <84sj2s75yv.wl%peter@chubb.wattle.id.au>
References: <84sj2s75yv.wl%peter@chubb.wattle.id.au>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 15 Apr 2013 08:23:21 +0100
Message-ID: <CAFEAcA_FTtC6Xu3myd2kgv-v=cTwKFmtF=7sYEm1B+QZEJ7XQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return
	statements.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Chubb <peter.chubb@nicta.com.au>
Cc: Japheth.Lim@nicta.com.au, qemu-devel@nongnu.org

On 15 April 2013 05:50, Peter Chubb <peter.chubb@nicta.com.au> wrote:
>
>
> Since patch
>    81465888c5306cd94abb9847e560796fd13d3c2f
>    target-arm: factor out handling of SRS instruction
> the SRS instruction has not worked in QEMU.
>
> The problem is a return directive that was removed in the
> refactoring, so after decoding the instruction, qemu would fall
> through to do stuff that it should not have done.

Nice catch for the ARM decoder, but not needed for thumb2
I think?

thanks
-- PMM