Re: [Qemu-devel] [PATCH] qdev: Deprecated qdev_init() is finally unused, drop

[Peter Maydell <peter.maydell@linaro.org>]

On 12 March 2015 at 14:54, Markus Armbruster <armbru@redhat.com> wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Depends on
> [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail()
> [PATCH] macio: Convert to realize()

Always nice to remove a deprecated API...

> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -66,7 +66,7 @@ struct VMStateDescription;
>   * After successful realization, setting static properties will fail.
>   *
>   * As an interim step, the #DeviceState:realized property is set by deprecated
> - * functions qdev_init() and qdev_init_nofail().
> + * function qdev_init_nofail().
>   * In the future, devices will propagate this state change to their children
>   * and along busses they expose.
>   * The point in time will be deferred to machine creation, so that values


So is the non-deprecated approach to have the board call
    object_property_set_bool(OBJECT(dev), true, "realized", &err);
directly itself (handling errors however it feels like) rather
than calling qdev_init_nofail() ?

-- PMM