From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YW4lR-0001gC-42
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:11:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YW4lM-0001rS-05
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:11:08 -0400
Received: from mail-lb0-f175.google.com ([209.85.217.175]:42059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YW4lL-0001rB-Pb
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:11:03 -0400
Received: by lbjb6 with SMTP id b6so16548680lbj.9
	for <qemu-devel@nongnu.org>; Thu, 12 Mar 2015 08:11:03 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1426172059-12237-1-git-send-email-armbru@redhat.com>
References: <1426172059-12237-1-git-send-email-armbru@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 12 Mar 2015 15:10:42 +0000
Message-ID: <CAFEAcA_FdA1_J4toQf=7FBS0WKXTNm_pe2TnEqOTQ24L5dMt3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] qdev: Deprecated qdev_init() is finally
 unused, drop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On 12 March 2015 at 14:54, Markus Armbruster <armbru@redhat.com> wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Depends on
> [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail()
> [PATCH] macio: Convert to realize()

Always nice to remove a deprecated API...

> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -66,7 +66,7 @@ struct VMStateDescription;
>   * After successful realization, setting static properties will fail.
>   *
>   * As an interim step, the #DeviceState:realized property is set by deprecated
> - * functions qdev_init() and qdev_init_nofail().
> + * function qdev_init_nofail().
>   * In the future, devices will propagate this state change to their children
>   * and along busses they expose.
>   * The point in time will be deferred to machine creation, so that values


So is the non-deprecated approach to have the board call
    object_property_set_bool(OBJECT(dev), true, "realized", &err);
directly itself (handling errors however it feels like) rather
than calling qdev_init_nofail() ?

-- PMM