From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98081C432C3 for ; Thu, 14 Nov 2019 10:24:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67A1120409 for ; Thu, 14 Nov 2019 10:24:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F9fExeWL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67A1120409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVCIb-0003oy-Gu for qemu-devel@archiver.kernel.org; Thu, 14 Nov 2019 05:24:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46406) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVCG8-0002rX-CK for qemu-devel@nongnu.org; Thu, 14 Nov 2019 05:21:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVCG7-0002B5-8p for qemu-devel@nongnu.org; Thu, 14 Nov 2019 05:21:52 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:32991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVCG7-0002AM-3x for qemu-devel@nongnu.org; Thu, 14 Nov 2019 05:21:51 -0500 Received: by mail-oi1-x243.google.com with SMTP id m193so4803964oig.0 for ; Thu, 14 Nov 2019 02:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OciApt82aTzB42BZpSEc3G5TI1Pt9KV/blSFY+IdHjQ=; b=F9fExeWLEqmzWsnY2w0xTnUWw+Y9EJZLKPqYjavN5mcumMnu8LNucayw9FRXOgRoS+ nbD6ErzyLs2JGAi+biLN5CbAbAVVzXdbmyHYgr6O85p+30Lp7szSHJKVDS/ehrmqUEn7 /pJQ2R4YZmrrU2IkrTNgwAKzqwPhTDNHT9xoibi4T7pwT/T5RKoN6twkW1V1w0GviAzK BnOI+Q2nu0T9mSa0NsOWg2xtSKzWL35QQFW1ESlWO/QN2r8ELRQHta51sb5KgSLTRvBL BbSkB4wDck8LDc6mJYNmppJDR/pKH5ne+S3ELWdFlYNEMYMGBJnFfttmrk1aASYbrzYv cIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OciApt82aTzB42BZpSEc3G5TI1Pt9KV/blSFY+IdHjQ=; b=K4vdvYl3/j7CfRSzhh92gaj5jn+yH6T1zZApfDRamVJmcVMKDfcZEGqM/Psfb1XgJe fyFBbgpzorPm+wt/aT8UM0+gJJFFoxWIKrC83Z4b+doU8O5rARm0Z2TX3OIyb0IpmulD SKA9tYQ7XUIUS8UFLSHw3vWfPiIFKX1qY6KD51nb38MZDwGHbohy1tNIL0N7Lp9wBZNu zurxDV6g8bTg6B7XPNi+xZEmHEGHN8CJ/bC1HT8xZEMGkDta/ICDdE30EAHqU5hWPfd9 x7kz9DGziUacoiqOikWRTXv88L80c83DjK3LnZ7wRitqm0zpPhBSDEenq2oBkQgYuQks 2DlQ== X-Gm-Message-State: APjAAAWt5A030eU9oHZ71qQ4SI5EHwS5yyhP/JYopbguB2UqB+NLYr41 dKcJSeZIKJ9wVP1h12e7+oETAY5DnFO6g946GAm8xg== X-Google-Smtp-Source: APXvYqy+6aub0QqgfgnbhYDcuv77J28J8TuK8Q/MTpREnuVy3OnlHwD3PqIZ/keUHudsitDSksM2AylwS5IkPai+D9A= X-Received: by 2002:aca:cf12:: with SMTP id f18mr2770231oig.48.1573726909683; Thu, 14 Nov 2019 02:21:49 -0800 (PST) MIME-Version: 1.0 References: <1573655945-14912-1-git-send-email-pbonzini@redhat.com> <1573655945-14912-2-git-send-email-pbonzini@redhat.com> <2db4f901-65ad-4b80-d309-b8b63330492f@redhat.com> <4783e606-19b8-c3c0-08ab-ac84b02af6f4@redhat.com> In-Reply-To: <4783e606-19b8-c3c0-08ab-ac84b02af6f4@redhat.com> From: Peter Maydell Date: Thu, 14 Nov 2019 10:21:38 +0000 Message-ID: Subject: Re: [PATCH 01/16] memory: do not look at current_machine->accel To: Paolo Bonzini Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , QEMU Developers , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 14 Nov 2019 at 09:36, Paolo Bonzini wrote: > > On 14/11/19 10:10, Thomas Huth wrote: > >> "info mtree" prints the wrong accelerator name if used with for example > >> "-machine accel=kvm:tcg". > > I had a quick look at the output of "info mtree" with and without > > "accel=kvm:tcg", but I could not spot any obvious places where it's > > wrong. Could you give an example? > > Indeed the commit message should say "info mtree -f". > > $ x86_64-softmmu/qemu-system-x86_64 -M microvm -enable-kvm -machine accel=kvm:tcg -monitor stdio > QEMU 4.1.50 monitor - type 'help' for more information > (qemu) info mtree -f > ... > FlatView #1 > AS "memory", root: system > AS "cpu-memory-0", root: system > Root memory region: system > 0000000000000000-00000000000effff (prio 0, ram): microvm.ram kvm:tcg > 00000000000f0000-00000000000fffff (prio 0, ram): pc.bios kvm:tcg > 0000000000100000-0000000007ffffff (prio 0, ram): microvm.ram @0000000000100000 kvm:tcg Why do we need to print the accelerator name for every memory region? Isn't it just a global property, or at least a property of the CPU ? thanks -- PMM