From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb9ag-0004L7-5g for qemu-devel@nongnu.org; Tue, 07 Feb 2017 12:30:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb9af-0004Uq-8z for qemu-devel@nongnu.org; Tue, 07 Feb 2017 12:30:06 -0500 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:32786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cb9af-0004Ud-2d for qemu-devel@nongnu.org; Tue, 07 Feb 2017 12:30:05 -0500 Received: by mail-wr0-x22c.google.com with SMTP id i10so42585373wrb.0 for ; Tue, 07 Feb 2017 09:30:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170131122416.10284-1-ppandit@redhat.com> References: <20170131122416.10284-1-ppandit@redhat.com> From: Peter Maydell Date: Tue, 7 Feb 2017 17:29:43 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P Cc: Qemu Developers , Wjjzhang , Jiang Xin , Prasad J Pandit , Alistair Francis , "Edgar E. Iglesias" On 31 January 2017 at 12:24, P J P wrote: > From: Prasad J Pandit > > Hello, > > In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode > register is used to control 's->blkcnt' value. One, this bit is not > relevant in single block transfers. Second, Transfer Mode register > value could be set such that 's->blkcnt' would not see an update > during multi block transfers. Thus leading to an infinite loop. > > This patch set attempts to correct 'Block Count Enable' bit usage. Edgar, Alistair: the zynq models are our major SDHCI user -- would you like to have a look at this patchset, please? thanks -- PMM