From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, jasowang@redhat.com,
qemu-devel@nongnu.org, Jesse Larrew <jlarrew@linux.vnet.ibm.com>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc
Date: Tue, 4 Jun 2013 09:33:16 +0100 [thread overview]
Message-ID: <CAFEAcA_J2=PyJ2UQEiC6eFbPHc3RKDKmOSmZ_ePtWw=WYwB_Qg@mail.gmail.com> (raw)
In-Reply-To: <392488894.3387176.1370331261300.JavaMail.root@redhat.com>
On 4 June 2013 08:34, Andrew Jones <drjones@redhat.com> wrote:
> I could send a v2 that fixes the 1 error and 2 warnings found in the context
> of this patch, but why? It's out of the scope of the patch (although I did
> use "cleanup" in the summary...), and it would hardly make a dent in this
> file's problems.
The idea is that we gradually bring the code closer into
line with QEMU's standards by (a) not allowing in new
code which doesn't follow the rules and (b) fixing old
code where it is in areas which a patch touches. This
gradually ratchets up the quality overall without being
huge "touch every line in a file" patches (which reduce
the functionality of git blame, among other things).
It really isn't a very onerous requirement in my opinion.
thanks
-- PMM
next prev parent reply other threads:[~2013-06-04 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:20 [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc Andrew Jones
2013-06-04 7:07 ` Jesse Larrew
2013-06-04 7:34 ` Andrew Jones
2013-06-04 7:54 ` Luigi Rizzo
2013-06-04 8:33 ` Peter Maydell [this message]
2013-06-04 8:53 ` Andrew Jones
2013-06-04 8:49 ` [Qemu-devel] [PATCH v2] " Andrew Jones
2013-06-04 11:02 ` Michael S. Tsirkin
2013-06-04 10:58 ` [Qemu-devel] [PATCH] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_J2=PyJ2UQEiC6eFbPHc3RKDKmOSmZ_ePtWw=WYwB_Qg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=drjones@redhat.com \
--cc=jasowang@redhat.com \
--cc=jlarrew@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).