qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 2/2] hw/arm/palm.c: Encapsulate misc GPIO handling in a device
Date: Mon, 13 Jul 2020 11:05:27 +0100	[thread overview]
Message-ID: <CAFEAcA_JCSs6BCCw-MYOO8RcyXQ_iNZ63KjuwqEPM7yuvWsdTA@mail.gmail.com> (raw)
In-Reply-To: <4c049b0c-f305-729a-748d-0a7742b496ed@amsat.org>

On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Why not make it a generic container in the MachineState and create
> the container in hw/core/machine.c::machine_initfn()?

I don't think we create containers like that for any other
machine, do we?

thanks
-- PMM


  reply	other threads:[~2020-07-13 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 21:42 [PATCH 0/2] hw/arm/palm.c: Fix Coverity issue CID 1421944 Peter Maydell
2020-06-28 21:42 ` [PATCH 1/2] hw/arm/palm.c: Detabify Peter Maydell
2020-07-12  0:18   ` Li Qiang
2020-07-13 10:49   ` Philippe Mathieu-Daudé
2020-06-28 21:42 ` [PATCH 2/2] hw/arm/palm.c: Encapsulate misc GPIO handling in a device Peter Maydell
2020-07-12  0:22   ` Li Qiang
2020-07-13  8:57   ` Philippe Mathieu-Daudé
2020-07-13 10:05     ` Peter Maydell [this message]
2020-07-13 10:21       ` Philippe Mathieu-Daudé
2020-07-13 10:31         ` Peter Maydell
2020-07-13 10:52           ` Philippe Mathieu-Daudé
2020-07-11 18:33 ` [PATCH 0/2] hw/arm/palm.c: Fix Coverity issue CID 1421944 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_JCSs6BCCw-MYOO8RcyXQ_iNZ63KjuwqEPM7yuvWsdTA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).