From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WtzmA-0005u8-6B
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:38:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wtzm4-0000kB-F5
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:38:14 -0400
Received: from mail-lb0-f179.google.com ([209.85.217.179]:33882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wtzm4-0000k5-8D
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:38:08 -0400
Received: by mail-lb0-f179.google.com with SMTP id c11so3084981lbj.10
	for <qemu-devel@nongnu.org>; Mon, 09 Jun 2014 06:38:07 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <cover.1402317549.git.riku.voipio@linaro.org>
References: <cover.1402317549.git.riku.voipio@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 9 Jun 2014 14:37:46 +0100
Message-ID: <CAFEAcA_KaeM3bs-JVgE1D8SVzTBysLRZcu2FQziARyGSBQO75Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PULL 00/18] linux-user fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 9 June 2014 13:46,  <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Mostly fixes, but a bigger rework in signal.c to allow compiling with gcc-4.9
>
> The following changes since commit 959e41473f2179850578482052fb73b913bc4e42:
>
>   slirp/arp: do not special-case bogus IP addresses (2014-06-09 01:49:28 +0200)
>
> are available in the git repository at:
>
>   git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream
>
> for you to fetch changes up to b4032ebd7dbfdc38430878c557c9c83c9f4ec2d0:
>
>   User mode support for Linux ELF files with no section header (2014-06-09 15:19:59 +0300)

Hi; I'm afraid this fails to build for me when building
m68k-linux-user:

/root/qemu/linux-user/signal.c: In function 'target_rt_restore_ucontext':
/root/qemu/linux-user/signal.c:5079:5: error: 'err' may be used
uninitialized in this function [-Werror=uninitialized]

because the function never sets 'err' but then
returns it.

(32-bit, ARM, gcc 4.7.2. I don't know why the other
compilers don't spot this; perhaps they inline the
function and then figure out that the unused return
value isn't actually ever used.)

thanks
-- PMM