From: Peter Maydell <peter.maydell@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Drew Jones <drjones@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Christoffer Dall <christoffer.dall@linaro.org>"Richard W.M.
Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board
Date: Mon, 8 Dec 2014 21:34:26 +0000 [thread overview]
Message-ID: <CAFEAcA_OYE-9v7pcVCd3RgwprYJW+NHEXRL0t9jF+UCubB2MPQ@mail.gmail.com> (raw)
In-Reply-To: <548615CE.10100@redhat.com>
On 8 December 2014 at 21:19, Laszlo Ersek <lersek@redhat.com> wrote:
> So the following in addition makes it work on TCG (x86_64) too:
>
> -----------------
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 7147fea..c2bc44c 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -31,7 +31,7 @@
> #include "qemu/config-file.h"
>
> #define FW_CFG_SIZE 2
> -#define FW_CFG_DATA_SIZE 1
> +#define FW_CFG_DATA_SIZE 8
> #define TYPE_FW_CFG "fw_cfg"
> #define FW_CFG_NAME "fw_cfg"
> #define FW_CFG_PATH "/machine/" FW_CFG_NAME
> -----------------
>
> It affects the memory_region_init_io() call in fw_cfg_initfn().
>
> I hope to submit a small v3 series soon.
If you do that don't you now try to define an ioport on
x86 that's 8 bytes wide? You probably also need to check
whether the ppc and sparc boards that use mmio fw_cfg
can handle the wider data register.
-- PMM
next prev parent reply other threads:[~2014-12-08 21:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 16:59 [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board Laszlo Ersek
2014-12-05 18:42 ` Peter Maydell
2014-12-05 18:53 ` Laszlo Ersek
2014-12-08 14:01 ` Laszlo Ersek
2014-12-08 14:41 ` Peter Maydell
2014-12-08 14:43 ` Peter Maydell
2014-12-08 19:39 ` Laszlo Ersek
2014-12-08 21:19 ` Laszlo Ersek
2014-12-08 21:34 ` Peter Maydell [this message]
2014-12-08 23:20 ` Laszlo Ersek
2014-12-08 23:18 ` Christopher Covington
2014-12-08 23:51 ` Peter Maydell
2014-12-09 0:05 ` Laszlo Ersek
2014-12-09 9:31 ` Gerd Hoffmann
2014-12-09 15:41 ` Laszlo Ersek
2014-12-09 15:47 ` Peter Maydell
2014-12-09 15:54 ` Richard W.M. Jones
2014-12-10 11:13 ` Paolo Bonzini
2014-12-10 13:10 ` Andrew Jones
2014-12-09 0:05 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_OYE-9v7pcVCd3RgwprYJW+NHEXRL0t9jF+UCubB2MPQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).