From: Peter Maydell <peter.maydell@linaro.org>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qiaonuohan@cn.fujitsu.com,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v2 1/2] dump: simplify a bit kdump get_next_page()
Date: Mon, 5 Sep 2022 14:27:41 +0100 [thread overview]
Message-ID: <CAFEAcA_PrFOTtY7OaoLpGJgdbvFHMt2jhaGKENaBHc2oaLCXDA@mail.gmail.com> (raw)
In-Reply-To: <20220905125741.95516-2-marcandre.lureau@redhat.com>
On Mon, 5 Sept 2022 at 13:57, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This should be functionally equivalent, but slightly easier to read,
> with simplified paths and checks at the end of the function.
>
> The following patch is a major rewrite to get rid of the assert().
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> dump/dump.c | 21 ++++++++-------------
> roms/SLOF | 2 +-
> 2 files changed, 9 insertions(+), 14 deletions(-)
> diff --git a/roms/SLOF b/roms/SLOF
> index 6b6c16b4b4..5b4c5acdcd 160000
> --- a/roms/SLOF
> +++ b/roms/SLOF
> @@ -1 +1 @@
> -Subproject commit 6b6c16b4b40763507cf1f518096f3c3883c5cf2d
> +Subproject commit 5b4c5acdcd552a4e1796aeca6bb700f6cbb0282d
This shouldn't be in here, right? (I'm guessing a rebase
accident -- git submodules have terrible ergonomics.)
-- PMM
next prev parent reply other threads:[~2022-09-05 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 12:57 [PATCH v2 0/2] Fix dumping in kdump format with non-aligned memory marcandre.lureau
2022-09-05 12:57 ` [PATCH v2 1/2] dump: simplify a bit kdump get_next_page() marcandre.lureau
2022-09-05 13:12 ` David Hildenbrand
2022-09-05 13:27 ` Peter Maydell [this message]
2022-09-05 13:33 ` Marc-André Lureau
2022-09-05 12:57 ` [PATCH v2 2/2] dump: fix kdump to work over non-aligned blocks marcandre.lureau
2022-09-06 20:11 ` Stefan Berger
2022-09-29 7:54 ` Marc-André Lureau
2022-10-06 15:05 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_PrFOTtY7OaoLpGJgdbvFHMt2jhaGKENaBHc2oaLCXDA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=david@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).