qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 0/1] vfio fix for QEMU 5.2-rc2
@ 2020-11-12 23:05 Alex Williamson
  2020-11-12 23:06 ` [PULL 1/1] Fix use after free in vfio_migration_probe Alex Williamson
  2020-11-13 11:36 ` [PULL 0/1] vfio fix for QEMU 5.2-rc2 Peter Maydell
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2020-11-12 23:05 UTC (permalink / raw)
  To: qemu-devel
  Cc: Alex Bennée, Kirti Wankhede, Philippe Mathieu-Daudé,
	David Edmondson

The following changes since commit cb5d19e8294486551c422759260883ed290226d9:

  Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112' into staging (2020-11-12 11:33:26 +0000)

are available in the Git repository at:

  git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20201112.0

for you to fetch changes up to e408aeef8663fd6e3075aef252404c55d710a75e:

  Fix use after free in vfio_migration_probe (2020-11-12 15:58:16 -0700)

----------------------------------------------------------------
VFIO update 2020-11-12

 * Fix coverity reported use-after-free (Kirti Wankhede)

----------------------------------------------------------------
Kirti Wankhede (1):
      Fix use after free in vfio_migration_probe

 hw/vfio/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] Fix use after free in vfio_migration_probe
  2020-11-12 23:05 [PULL 0/1] vfio fix for QEMU 5.2-rc2 Alex Williamson
@ 2020-11-12 23:06 ` Alex Williamson
  2020-11-13 11:36 ` [PULL 0/1] vfio fix for QEMU 5.2-rc2 Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2020-11-12 23:06 UTC (permalink / raw)
  To: qemu-devel
  Cc: Philippe Mathieu-Daudé, Kirti Wankhede, Alex Bennée,
	David Edmondson

From: Kirti Wankhede <kwankhede@nvidia.com>

Fixes Coverity issue:
CID 1436126:  Memory - illegal accesses  (USE_AFTER_FREE)

Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize function")
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: David Edmondson <dme@dme.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/migration.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 3ce285ea395d..55261562d4f3 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp)
         goto add_blocker;
     }
 
-    g_free(info);
     trace_vfio_migration_probe(vbasedev->name, info->index);
+    g_free(info);
     return 0;
 
 add_blocker:



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] vfio fix for QEMU 5.2-rc2
  2020-11-12 23:05 [PULL 0/1] vfio fix for QEMU 5.2-rc2 Alex Williamson
  2020-11-12 23:06 ` [PULL 1/1] Fix use after free in vfio_migration_probe Alex Williamson
@ 2020-11-13 11:36 ` Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-11-13 11:36 UTC (permalink / raw)
  To: Alex Williamson
  Cc: Philippe Mathieu-Daudé, Kirti Wankhede, Alex Bennée,
	QEMU Developers, David Edmondson

On Thu, 12 Nov 2020 at 23:07, Alex Williamson
<alex.williamson@redhat.com> wrote:
>
> The following changes since commit cb5d19e8294486551c422759260883ed290226d9:
>
>   Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112' into staging (2020-11-12 11:33:26 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20201112.0
>
> for you to fetch changes up to e408aeef8663fd6e3075aef252404c55d710a75e:
>
>   Fix use after free in vfio_migration_probe (2020-11-12 15:58:16 -0700)
>
> ----------------------------------------------------------------
> VFIO update 2020-11-12
>
>  * Fix coverity reported use-after-free (Kirti Wankhede)
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-13 11:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 23:05 [PULL 0/1] vfio fix for QEMU 5.2-rc2 Alex Williamson
2020-11-12 23:06 ` [PULL 1/1] Fix use after free in vfio_migration_probe Alex Williamson
2020-11-13 11:36 ` [PULL 0/1] vfio fix for QEMU 5.2-rc2 Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).